arc: Add icon resource for the notification in migration-skipped session.

chrome/browser/chromeos/arc/arc_migration_guide_notification.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/arc/arc_migration_guide_notification.h"
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
+#include "chrome/app/vector_icons/vector_icons.h"
 #include "chrome/browser/chromeos/arc/arc_util.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/ash/multi_user/multi_user_util.h"
 #include "chrome/grit/generated_resources.h"
-#include "chrome/grit/theme_resources.h"
 #include "components/signin/core/account_id/account_id.h"
 #include "ui/base/l10n/l10n_util.h"
-#include "ui/base/resource/resource_bundle.h"
+#include "ui/gfx/paint_vector_icon.h"
 #include "ui/message_center/message_center.h"
 #include "ui/message_center/notification.h"
 #include "ui/message_center/notification_delegate.h"
 
 namespace arc {
 
 namespace {
 
 constexpr char kNotifierId[] = "arc_fs_migration";
 constexpr char kNotificationId[] = "arc_fs_migration/migrate";
@@ skipping 22 matching lines @@
                                                            false /* by_user */);
 
   message_center::NotifierId notifier_id(
       message_center::NotifierId::SYSTEM_COMPONENT, kNotifierId);
   notifier_id.profile_id =
       multi_user_util::GetAccountIdFromProfile(profile).GetUserEmail();
 
   message_center::RichNotificationData data;
   data.buttons.push_back(message_center::ButtonInfo(l10n_util::GetStringUTF16(
       IDS_ARC_MIGRATE_ENCRYPTION_NOTIFICATION_RESTART_BUTTON)));
-  ui::ResourceBundle& resource_bundle = ui::ResourceBundle::GetSharedInstance();
   message_center::MessageCenter::Get()->AddNotification(
       base::MakeUnique<message_center::Notification>(
           message_center::NOTIFICATION_TYPE_SIMPLE, kNotificationId,
           l10n_util::GetStringUTF16(
               IDS_ARC_MIGRATE_ENCRYPTION_NOTIFICATION_TITLE),
           // TODO(kinaba): crbug/710289 Change message for low-battery case.
           l10n_util::GetStringUTF16(
               IDS_ARC_MIGRATE_ENCRYPTION_NOTIFICATION_MESSAGE),
-          // TODO(kinaba): crbug/710285 Replace the icon with the final design.
-          resource_bundle.GetImageNamed(IDR_ARC_PLAY_STORE_NOTIFICATION),
+          gfx::Image(gfx::CreateVectorIcon(

[Evan Stade, 2017/04/14 14:46:41]

I believe you need to specify a size or this icon will be created at 112x112
dip. (It may look normal anyway because we're scaling it down in the UI but
that's not optimal.)

It looks like this icon only actually uses 80x80 dip (extra 16dip of padding on
all sides built in) which aligns with the 80 of kNotificationIconSize.

Anyway, I'm pretty confused about this --- could you post a screenshot?

[kinaba, 2017/04/17 08:08:55]

elizabethchiu@

Here's the screenshot:
https://drive.google.com/file/d/0B5GWhwdfG_jTdVFJWjFZOFlZajA/view?usp=sharing

From the UI mock I guessed that there's the intentional margin otherwise the
image fills up to the border of the notification popup.

+              kArcMigrateEncryptionNotificationIcon, SK_ColorTRANSPARENT)),

[Evan Stade, 2017/04/14 14:46:41]

if you don't need to pass a color (because all the colors are defined in the
icon) you should use gfx::kPlaceholderColor. However I suspect you put
transparent to make that extra box in the .icon file go away.

[kinaba, 2017/04/17 08:08:55]

Done.

           base::string16(), GURL(), notifier_id, data,
           new ArcMigrationGuideNotificationDelegate()));
 }
 
 }  // namespace arc