Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: chrome/android/java/strings/android_chrome_strings.grd

Issue 2820423003: Add strings which will be used in new translate infobar. (Closed)
Patch Set: remove meaning Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/strings/android_chrome_strings.grd
diff --git a/chrome/android/java/strings/android_chrome_strings.grd b/chrome/android/java/strings/android_chrome_strings.grd
index 7204c8b507d31321645250b5030321b74554b043..bfccb8a97eb16167398c09729c2168da12b57183 100644
--- a/chrome/android/java/strings/android_chrome_strings.grd
+++ b/chrome/android/java/strings/android_chrome_strings.grd
@@ -1560,9 +1560,28 @@ To obtain new licenses, connect to the internet and play your downloaded content
<message name="IDS_TRANSLATE_NEVER_TRANSLATE_SITE" desc="Text to display on the never translate site (like www.google.com) button. [CHAR-LIMIT=64]">
Never translate this site
</message>
- <message name="IDS_TRANSLATE_NEVER_TRANSLATE_LANGUAGE" meaning="Android" desc="Text to display on the never translate language button. [CHAR-LIMIT=64]">
+ <message name="IDS_TRANSLATE_NEVER_TRANSLATE_LANGUAGE" desc="Text to display on the never translate language button. [CHAR-LIMIT=64]">
srahim 2017/04/20 04:33:17 Please update message description: desc="Text tha
Leo 2017/04/20 05:31:31 Desc is updated. This was the old translate info
Never translate <ph name="LANGUAGE">%1$s<ex>French</ex></ph>
</message>
+ <message name="IDS_TRANSLATE_INFOBAR_MORE_LANGUAGE" desc="Menu item for selecting another target language to translate. [CHAR-LIMIT=64]">
srahim 2017/04/20 04:33:17 Please revise message description, it's not quite
+ More languages
+ </message>
+ <message name="IDS_TRANSLATE_INFOBAR_NOT_THIS_LANGUAGE" desc="Menu item for selecting another language as source language to translate. [CHAR-LIMIT=64]">
+ Page is not in <ph name="LANGUAGE">%1$s<ex>French</ex></ph>
+ </message>
+ <message name="IDS_TRANSLATE_SNACKBAR_ALWAYS_TRANSLATED" desc="Text to be displayed in translate snackbar that lets the user know pages in this source language will not be translated to target language automatically. [CHAR-LIMIT=64]">
srahim 2017/04/20 04:33:17 Please check the message description. The message
Leo 2017/04/20 05:31:32 Thanks for the catch. Fixed.
+ Sites in <ph name="SOURCE_LANGUAGE">%1$s<ex>French</ex></ph> will be translated to <ph name="TARGET_LANGUAGE">%2$s<ex>English</ex></ph>
+ </message>
+ <message name="IDS_TRANSLATE_SNACKBAR_LANGUAGE_NEVER" desc="Text to be displayed in translate snackbar that lets the user know sites in this language not be translated. [CHAR-LIMIT=64]">
srahim 2017/04/20 04:33:17 Minor nit in the message description so translator
Leo 2017/04/20 05:31:32 Thanks for the catch.
+ Sites in <ph name="LANGUAGE">%1$s<ex>French</ex></ph> will not be translated
+ </message>
+ <message name="IDS_TRANSLATE_SNACKBAR_SITE_NEVER" desc="Text to be displayed in translate snackbar that lets the user know this site will not be translated. [CHAR-LIMIT=64]">
+ This site will not be translated
+ </message>
+ <message name="IDS_TRANSLATE_SNACKBAR_CANCEL" desc="A text label on the translate snackbar widget to cancel the this selection. [CHAR-LIMIT=16]">
+ Cancel
+ </message>
+
<message name="IDS_MENU_PRINT" desc="Menu item for printing the current page. [CHAR-LIMIT=27]">
Print…
</message>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698