Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1837)

Unified Diff: net/quic/core/congestion_control/bbr_sender_test.cc

Issue 2820413002: Tweak BBR tests with the keep sending flag enabled to consistently pass unit tests. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/congestion_control/bbr_sender_test.cc
diff --git a/net/quic/core/congestion_control/bbr_sender_test.cc b/net/quic/core/congestion_control/bbr_sender_test.cc
index 049b7ce4860e9b99d01f4e279f8dfd813ce7364d..1923f930539485671cca7f6f2e0fabcf3938c2aa 100644
--- a/net/quic/core/congestion_control/bbr_sender_test.cc
+++ b/net/quic/core/congestion_control/bbr_sender_test.cc
@@ -340,7 +340,7 @@ TEST_F(BbrSenderTest, SimpleTransfer2RTTAggregationKeepSending) {
EXPECT_FALSE(sender_->ExportDebugState().last_sample_is_app_limited);
// The margin here is high, because the aggregation greatly increases
// smoothed rtt.
- EXPECT_GE(kTestRtt * 4, rtt_stats_->smoothed_rtt());
+ EXPECT_GE(kTestRtt * 4.5, rtt_stats_->smoothed_rtt());
ExpectApproxEq(kTestRtt, rtt_stats_->min_rtt(), 0.1f);
}
@@ -382,6 +382,7 @@ TEST_F(BbrSenderTest, SimpleTransferAckDecimation) {
TEST_F(BbrSenderTest, SimpleTransferAckDecimationKeepSending) {
FLAGS_quic_reloadable_flag_quic_bbr_ack_aggregation_bytes = false;
+ FLAGS_quic_reloadable_flag_quic_bbr_add_tso_cwnd = true;
FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate = true;
// Decrease the CWND gain so extra CWND is required with stretch acks.
base::SetFlag(&FLAGS_quic_bbr_cwnd_gain, 1.0);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698