Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: ios/chrome/browser/metrics/tab_usage_recorder.h

Issue 2820383002: [ObjC ARC] Converts ios/chrome/browser/metrics:metrics_internal to ARC. (Closed)
Patch Set: remove empty line Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/metrics/size_class_recorder.mm ('k') | ios/chrome/browser/metrics/tab_usage_recorder.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/metrics/tab_usage_recorder.h
diff --git a/ios/chrome/browser/metrics/tab_usage_recorder.h b/ios/chrome/browser/metrics/tab_usage_recorder.h
index 8b99125161c1c9eb2b05b5cef16c5232b26e2d96..b5a3e217e1b39473b1ce4c4a3a446f9932b95a25 100644
--- a/ios/chrome/browser/metrics/tab_usage_recorder.h
+++ b/ios/chrome/browser/metrics/tab_usage_recorder.h
@@ -191,7 +191,7 @@ class TabUsageRecorder {
// Keep track of the current tab, but only if it has been evicted.
// This is kept as a pointer value only - it should never be dereferenced.
- void* evicted_tab_;
+ __unsafe_unretained Tab* evicted_tab_;
// State of |evicted_tab_| at the time it became the current tab.
TabStateWhenSelected evicted_tab_state_;
@@ -199,11 +199,11 @@ class TabUsageRecorder {
// Keep track of the tab last selected when this tab model was switched
// away from to another mode (e.g. to incognito).
// Kept as a pointer value only - it should never be dereferenced.
- void* mode_switch_tab_;
+ __unsafe_unretained Tab* mode_switch_tab_;
// Keep track of a tab that was created to be immediately selected. It should
// not contribute to the "StatusWhenSwitchedBackToForeground" metric.
- void* tab_created_selected_;
+ __unsafe_unretained Tab* tab_created_selected_;
// Keep track of when the evicted tab starts to reload, so that the total
// time it takes to reload can be recorded.
« no previous file with comments | « ios/chrome/browser/metrics/size_class_recorder.mm ('k') | ios/chrome/browser/metrics/tab_usage_recorder.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698