Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Side by Side Diff: runtime/vm/kernel_reader.h

Issue 2820363002: Move Kernel strings into the VM's heap. (Closed)
Patch Set: Incorporate review comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/kernel_binary_flowgraph.cc ('k') | runtime/vm/kernel_reader.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef RUNTIME_VM_KERNEL_READER_H_ 5 #ifndef RUNTIME_VM_KERNEL_READER_H_
6 #define RUNTIME_VM_KERNEL_READER_H_ 6 #define RUNTIME_VM_KERNEL_READER_H_
7 7
8 #if !defined(DART_PRECOMPILED_RUNTIME) 8 #if !defined(DART_PRECOMPILED_RUNTIME)
9 #include <map> 9 #include <map>
10 10
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 static void SetupFunctionParameters(TranslationHelper translation_helper_, 59 static void SetupFunctionParameters(TranslationHelper translation_helper_,
60 DartTypeTranslator type_translator_, 60 DartTypeTranslator type_translator_,
61 const dart::Class& owner, 61 const dart::Class& owner,
62 const dart::Function& function, 62 const dart::Function& function,
63 FunctionNode* kernel_function, 63 FunctionNode* kernel_function,
64 bool is_method, 64 bool is_method,
65 bool is_closure); 65 bool is_closure);
66 66
67 void ReadLibrary(Library* kernel_library); 67 void ReadLibrary(Library* kernel_library);
68 68
69 const dart::String& DartSymbol(String* str) {
70 return translation_helper_.DartSymbol(str);
71 }
72
73 uint8_t CharacterAt(String* str, intptr_t index);
74
69 private: 75 private:
70 friend class BuildingTranslationHelper; 76 friend class BuildingTranslationHelper;
71 77
72 void ReadPreliminaryClass(dart::Class* klass, Class* kernel_klass); 78 void ReadPreliminaryClass(dart::Class* klass, Class* kernel_klass);
73 dart::Class& ReadClass(const dart::Library& library, 79 dart::Class& ReadClass(const dart::Library& library,
74 const dart::Class& toplevel_class, 80 const dart::Class& toplevel_class,
75 Class* kernel_klass); 81 Class* kernel_klass);
76 void ReadProcedure(const dart::Library& library, 82 void ReadProcedure(const dart::Library& library,
77 const dart::Class& owner, 83 const dart::Class& owner,
78 Procedure* procedure, 84 Procedure* procedure,
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 120
115 GrowableArray<const dart::Function*> functions_; 121 GrowableArray<const dart::Function*> functions_;
116 GrowableArray<const dart::Field*> fields_; 122 GrowableArray<const dart::Field*> fields_;
117 }; 123 };
118 124
119 } // namespace kernel 125 } // namespace kernel
120 } // namespace dart 126 } // namespace dart
121 127
122 #endif // !defined(DART_PRECOMPILED_RUNTIME) 128 #endif // !defined(DART_PRECOMPILED_RUNTIME)
123 #endif // RUNTIME_VM_KERNEL_READER_H_ 129 #endif // RUNTIME_VM_KERNEL_READER_H_
OLDNEW
« no previous file with comments | « runtime/vm/kernel_binary_flowgraph.cc ('k') | runtime/vm/kernel_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698