third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h - Issue 2820343004: [DMC #4] Add CompositionMarkerListImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

Issue 2820343004: [DMC #4] Add CompositionMarkerListImpl (Closed)

Patch Set: Add comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp ('K') | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp ('k') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

index fc9e69c8eaf780ef1c0deb9f6739c0299ba49019..8897a250080e41da80648dc75ad1e0b2bb1b4a79 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

@@ -44,7 +44,7 @@ class CORE_EXPORT DocumentMarkerList

// TODO(rlanday): remove this method from this interface once we have a

// Spelling/Grammar-specific marker list impl to put this on

virtual bool RemoveMarkersUnderWords(const String& node_text,

- const Vector<String>& words) = 0;

+ const Vector<String>& words);

// Returns true if at least one marker is shifted or removed, false otherwise

virtual bool ShiftMarkers(unsigned offset,