Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp

Issue 2820343004: [DMC #4] Add CompositionMarkerListImpl (Closed)
Patch Set: Fix nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp
diff --git a/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp b/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp
index 5f0b66d71a7289b337e46ae6c2cb7203da3f3f19..bc83f4d1568c036d293a15a830e9fd0e4cd66693 100644
--- a/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp
+++ b/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp
@@ -20,10 +20,11 @@ void GenericDocumentMarkerListImpl::Add(DocumentMarker* marker) {
DocumentMarkerListEditor::AddMarkerAndMergeOverlapping(&markers_, marker);
return;
case DocumentMarker::kTextMatch:
- case DocumentMarker::kComposition:
DocumentMarkerListEditor::AddMarkerWithoutMergingOverlapping(&markers_,
marker);
return;
+ case DocumentMarker::kComposition:
+ NOTREACHED();
}
NOTREACHED() << "Unhanded marker type: " << marker->GetType();
« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698