third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp - Issue 2820343004: [DMC #4] Add CompositionMarkerListImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp

Issue 2820343004: [DMC #4] Add CompositionMarkerListImpl (Closed)

Patch Set: DECLARE_VIRTUAL_TRACE() Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/markers/CompositionMarkerListImpl.cpp ('K') | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp b/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp

index 3c4ceb3289296a65bf76646083c1da8976def1b4..cbe0675c29da1af6c99e9fd3bfc533ab2d6327d4 100644

--- a/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp

@@ -20,10 +20,11 @@ void GenericDocumentMarkerListImpl::Add(DocumentMarker* marker) {

DocumentMarkerListEditor::AddMarkerAndMergeOverlapping(&markers_, marker);

return;

case DocumentMarker::kTextMatch:

- case DocumentMarker::kComposition:

DocumentMarkerListEditor::AddMarkerWithoutMergingOverlapping(&markers_,

marker);

return;

+ case DocumentMarker::kComposition:

+ NOTREACHED();

}

NOTREACHED();