[DMC #4] Add CompositionMarkerListImpl

third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp

Index: third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp
diff --git a/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp b/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp
index 3c4ceb3289296a65bf76646083c1da8976def1b4..cbe0675c29da1af6c99e9fd3bfc533ab2d6327d4 100644
--- a/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp
+++ b/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp
@@ -20,10 +20,11 @@ void GenericDocumentMarkerListImpl::Add(DocumentMarker* marker) {
       DocumentMarkerListEditor::AddMarkerAndMergeOverlapping(&markers_, marker);
       return;
     case DocumentMarker::kTextMatch:
-    case DocumentMarker::kComposition:
       DocumentMarkerListEditor::AddMarkerWithoutMergingOverlapping(&markers_,
                                                                    marker);
       return;
+    case DocumentMarker::kComposition:

[Xiaocheng, 2017/04/27 17:49:41]

nit: There's no need to add another NOTREACHED(), as it will be captured by the
NOTREACHED() at the end.

[rlanday, 2017/04/27 18:01:02]

I'd have to write "break" or something anyway (I can't leave the case out
entirely
without adding a default case, which I generally like to avoid because then
someone
could add a new case and forget to update some of the switch statements)

[Xiaocheng, 2017/04/27 18:09:15]

All right, fine.

+      NOTREACHED();
   }
 
   NOTREACHED();