Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2820323005: Run formatter on a few frontend and kernel files that hadn't been formatted. (Closed)

Created:
3 years, 8 months ago by Jacob
Modified:
3 years, 8 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Run formatter on a few frontend and kernel files that hadn't been formatted. BUG= R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/997b4e62af850eb6a325d50f66da0e72417cfd4e

Patch Set 1 #

Patch Set 2 : Run formatter on a few frontend and kernel files that hadn't been formatted. #

Patch Set 3 : Run formatter on a few frontend and kernel files that hadn't been formatted. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -163 lines) Patch
M pkg/front_end/lib/src/fasta/analyzer/compile_platform_dartk.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/test/scanner_replacement_test.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M pkg/front_end/testcases/cascade.dart View 1 1 chunk +15 lines, -13 lines 0 comments Download
M pkg/front_end/testcases/cycles.dart View 1 1 chunk +4 lines, -8 lines 0 comments Download
M pkg/front_end/testcases/expressions.dart View 1 4 chunks +4 lines, -1 line 0 comments Download
M pkg/front_end/testcases/functions.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/testcases/invocations.dart View 1 1 chunk +6 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/mixin.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/testcases/platform.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/testcases/rasta/bad_default_constructor.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/testcases/rasta/class_hierarchy.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/rasta/duplicated_mixin.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/testcases/rasta/external_factory_redirection.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/rasta/generic_factory.dart View 1 2 chunks +5 lines, -10 lines 0 comments Download
M pkg/front_end/testcases/rasta/issue_000007.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/rasta/issue_000025.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/rasta/issue_000033.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/testcases/rasta/issue_000052.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/testcases/rasta/issue_000053.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/testcases/rasta/issue_000067.dart View 1 1 chunk +6 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/rasta/issue_000068.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/rasta/issue_000069.dart View 1 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/rasta/issue_000070.dart View 1 2 chunks +5 lines, -7 lines 0 comments Download
M pkg/front_end/testcases/rasta/super_initializer.dart View 1 1 chunk +9 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/rasta/super_mixin.dart View 1 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/rasta/super_operator.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/front_end/testcases/rasta/switch_fall_through.dart View 1 2 chunks +12 lines, -14 lines 0 comments Download
M pkg/front_end/testcases/rasta/type_literals.dart View 1 1 chunk +8 lines, -8 lines 0 comments Download
M pkg/front_end/testcases/redirecting_constructor.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M pkg/kernel/lib/binary/ast_from_binary.dart View 6 chunks +28 lines, -25 lines 0 comments Download
M pkg/kernel/lib/class_hierarchy.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/kernel/lib/clone.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/kernel/lib/frontend/accessors.dart View 5 chunks +17 lines, -17 lines 0 comments Download
M pkg/kernel/lib/transformations/closure/converter.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/kernel/lib/transformations/closure/mock.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/kernel/lib/transformations/continuation.dart View 6 chunks +13 lines, -7 lines 0 comments Download
M pkg/kernel/lib/transformations/method_call.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/kernel/lib/transformations/mixin_full_resolution.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Jacob
3 years, 8 months ago (2017-04-18 22:04:52 UTC) #2
asgerf
LGTM, though wasn't there talk of changing the extension of files that should be seen ...
3 years, 8 months ago (2017-04-19 09:14:51 UTC) #3
Jacob
On 2017/04/19 09:14:51, asgerf wrote: > LGTM, though wasn't there talk of changing the extension ...
3 years, 8 months ago (2017-04-20 16:17:52 UTC) #4
Jacob
3 years, 8 months ago (2017-04-20 16:25:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
997b4e62af850eb6a325d50f66da0e72417cfd4e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698