Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

Issue 2820233002: Always report maybe-clipped when painting fragmented content (Closed)
Patch Set: none Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp b/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
index 0a6cd48300b7e41f78ac9b20ab5826a3b42661dc..ef3a824876e161269e1d75877fb04f82af1a85d0 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
@@ -470,6 +470,11 @@ PaintResult PaintLayerPainter::PaintLayerContents(
geometry_mapper_option, kIgnorePlatformOverlayScrollbarSize,
respect_overflow_clip, &offset_from_root,
local_painting_info.sub_pixel_accumulation);
+ // PaintLayer::collectFragments depends on the paint dirty rect in
+ // complicated ways. For now, always assume a partially painted output
+ // for fragmented content.
+ if (layer_fragments.size() > 1)
+ result = kMayBeClippedByPaintDirtyRect;
}
if (paint_flags & kPaintLayerPaintingAncestorClippingMaskPhase) {
@@ -697,6 +702,7 @@ PaintResult PaintLayerPainter::PaintLayerWithTransform(
if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled())
geometry_mapper_option = PaintLayer::kUseGeometryMapper;
+ PaintResult result = kFullyPainted;
PaintLayer* pagination_layer = paint_layer_.EnclosingPaginationLayer();
PaintLayerFragments layer_fragments;
bool is_fixed_position_object_in_paged_media =
@@ -739,6 +745,11 @@ PaintResult PaintLayerPainter::PaintLayerWithTransform(
painting_info.paint_dirty_rect, cache_slot, geometry_mapper_option,
kIgnorePlatformOverlayScrollbarSize, respect_overflow_clip, nullptr,
painting_info.sub_pixel_accumulation, &transformed_extent);
+ // PaintLayer::collectFragments depends on the paint dirty rect in
+ // complicated ways. For now, always assume a partially painted output
+ // for fragmented content.
+ if (layer_fragments.size() > 1)
+ result = kMayBeClippedByPaintDirtyRect;
}
Optional<DisplayItemCacheSkipper> cache_skipper;
@@ -764,7 +775,6 @@ PaintResult PaintLayerPainter::PaintLayerWithTransform(
}
}
- PaintResult result = kFullyPainted;
for (const auto& fragment : layer_fragments) {
Optional<LayerClipRecorder> clip_recorder;
if (parent_layer && !RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {

Powered by Google App Engine
This is Rietveld 408576698