Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4006)

Unified Diff: build/android/binary_size/apks/README.md

Issue 2820163003: Android: update patch size reference APKs for m59. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/binary_size/apks/Android_arm64_Builder/59/ChromePublic.apk.sha1 ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/binary_size/apks/README.md
diff --git a/build/android/binary_size/apks/README.md b/build/android/binary_size/apks/README.md
index 474ba93c432ec01a39ea9581baf48de93e94bd58..8bbe6354c812d2b25da547a5b56149c084ae04a7 100644
--- a/build/android/binary_size/apks/README.md
+++ b/build/android/binary_size/apks/README.md
@@ -4,21 +4,24 @@
latest builds are m59, we want to compare to the commit before the m58 branch
point).
-2. Download and unzip build artifacts from the relevant perf builder. You can
-use this link:
-[https<nolink>://storage.cloud.google.com/chrome-perf/**Android%20Builder**/full-build-linux_**3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a**.zip](https://storage.cloud.google.com/chrome-perf/Android%20Builder/full-build-linux_3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a.zip)
-, replacing the bolded parts with your info OR from the
-"gsutil upload_build_product" step on the bot page (both are Googlers only).
-
-3. Upload the apk: _upload_to_google_storage.py --bucket
-'chromium-android-tools/apks/**Android_Builder**/**58**'
-**path/to/ApkTarget.apk**_ replacing the bolded parts again.
- * Note that we use **Android_Builder** instead of **Android Builder** (replace
-spaces with underscores)
-
-4. Move the generated .sha1 file to the corresponding place in
-//build/android/binary_size/apks/. In this case, the path would be
-//build/android/binary_size/apks/Android_Builder/58
-
-5. Commit the added .sha1 files and (optionally) update the `CURRENT_MILESTONE`
+2. Download and unzip build artifacts from the relevant perf builder.
+
+ gsutil.py cp 'gs://chrome-perf/Android Builder/full-build-linux_COMMITHASH.zip' /dest/dir
+
+3. Unzip. Steps 4, 5, and 6 must be done for MonochromePublic.apk for
+`gs://chrome-perf/Android Builder` and ChromeModernPublic.apk for
+`gs://chrome-perf/Android arm64 Builder` (and can be done for additional APKS,
+but these are the ones used by `build/android/resource_sizes.py`)
+
+4. Upload the apk (replacing the bolded parts again - note that we use
+**Android_Builder** instead of **Android Builder** (replace spaces with
+underscores):
+
+ upload_to_google_storage.py --bucket 'chromium-android-tools/apks/Android_Builder/58' dest/dir/MonochromePublic.apk
+
+5. Move the generated .sha1 file to the corresponding place in
+`//build/android/binary_size/apks/`. In this case, the path would be
+`//build/android/binary_size/apks/Android_Builder/58`
+
+6. Commit the added .sha1 files and (optionally) update the `CURRENT_MILESTONE`
in apk_downloader.py
« no previous file with comments | « build/android/binary_size/apks/Android_arm64_Builder/59/ChromePublic.apk.sha1 ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698