chrome/browser/resources/md_bookmarks/folder_node.html - Issue 2820153003: [MD Bookmarks] Add keyboard navigation to sidebar.

Unified Diff: chrome/browser/resources/md_bookmarks/folder_node.html

Issue 2820153003: [MD Bookmarks] Add keyboard navigation to sidebar. (Closed)

Patch Set: select_on_move Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/md_bookmarks/folder_node.html

diff --git a/chrome/browser/resources/md_bookmarks/folder_node.html b/chrome/browser/resources/md_bookmarks/folder_node.html

index 7f38457b8be7b3229f8b8fa479c91ee6a7281a66..5c6f092250fcb2f47d491a4501a84b0b5a3c4cc6 100644

--- a/chrome/browser/resources/md_bookmarks/folder_node.html

+++ b/chrome/browser/resources/md_bookmarks/folder_node.html

@@ -82,10 +82,11 @@

<div id="container" class="v-centered" on-tap="selectFolder_"

draggable="[[!isRootFolder_(depth)]]"

+ tabindex$="[[getTabIndex_(isSelectedFolder_)]]"

hidden="[[!isPositiveDepth_(depth)]]">

<paper-icon-button id="arrow" icon="cr:arrow-drop-down"

- is-open$="[[!isClosed_]]" on-tap="toggleFolder_">

+ is-open$="[[!isClosed_]]" on-tap="toggleFolder_" tabindex="">

tsergeant 2017/04/19 07:32:17 Should this be tabindex="-1"?

calamity 2017/04/28 06:15:47 I think this is a little better. -1 is still focus

tsergeant 2017/05/01 01:35:57 I'm not sure what you mean by "focuses the list"?

calamity 2017/05/03 03:01:47 Discussed.

</paper-icon-button>

</template>