Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl

Issue 2820113006: Remove AudioBufferCallback (Closed)
Patch Set: Clean up includes. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl
diff --git a/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl b/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl
index d8d4d6d9eebafe048099e3035c94c5887b8aebad..e297540f9c0d0b761f76b684daedb2bd258f4cb1 100644
--- a/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl
+++ b/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl
@@ -3,6 +3,10 @@
// found in the LICENSE file.
// See https://webaudio.github.io/web-audio-api/#BaseAudioContext
+
+callback DecodeSuccessCallback = void (AudioBuffer decodedData);
jsbell 2017/04/19 17:23:14 totally silly nit: If you move these down below th
foolip 2017/04/20 11:32:50 FWIW, I like it when the order matches the spec to
Raymond Toy 2017/04/20 15:21:40 Done.
+callback DecodeErrorCallback = void (DOMException error);
+
enum AudioContextState {
"suspended",
"running",
@@ -31,7 +35,7 @@ enum AudioContextState {
[RaisesException] AudioBuffer createBuffer(unsigned long numberOfChannels, unsigned long numberOfFrames, float sampleRate);
// Asynchronous audio file data decoding.
- [RaisesException, MeasureAs=AudioContextDecodeAudioData, CallWith=ScriptState] Promise<AudioBuffer> decodeAudioData(ArrayBuffer audioData, optional AudioBufferCallback successCallback, optional AudioBufferCallback errorCallback);
+ [RaisesException, MeasureAs=AudioContextDecodeAudioData, CallWith=ScriptState] Promise<AudioBuffer> decodeAudioData(ArrayBuffer audioData, optional DecodeSuccessCallback successCallback, optional DecodeErrorCallback errorCallback);
// Sources
[RaisesException, MeasureAs=AudioContextCreateBufferSource] AudioBufferSourceNode createBufferSource();

Powered by Google App Engine
This is Rietveld 408576698