components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc - Issue 2820063005: Remove the "not_after" validation of policy timestamps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc

Issue 2820063005: Remove the "not_after" validation of policy timestamps (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/component_cloud_policy_store.cc ('k') | components/policy/core/common/cloud/user_cloud_policy_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc

diff --git a/components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc b/components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc

index e891c3f9e39d03c49e8cf4ba3ed80bed1c33fd91..643f62e147a2908e7b00ae67191793f8a8d176aa 100644

--- a/components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc

+++ b/components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc

@@ -181,15 +181,6 @@ TEST_F(ComponentCloudPolicyStoreTest, ValidatePolicyWrongTimestamp) {

EXPECT_FALSE(store_->ValidatePolicy(kTestPolicyNS, CreateResponse(),

nullptr /* policy_data */,

nullptr /* payload */));

- const int64_t kFutureTimestamp =

- (base::Time::NowFromSystemTime() + base::TimeDelta::FromDays(1) -

- base::Time::UnixEpoch())

- .InMilliseconds();

- builder_.policy_data().set_timestamp(kFutureTimestamp);

- EXPECT_FALSE(store_->ValidatePolicy(kTestPolicyNS, CreateResponse(),

- nullptr /* policy_data */,

- nullptr /* payload */));

}

TEST_F(ComponentCloudPolicyStoreTest, ValidatePolicyWrongUsername) {