Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4786)

Unified Diff: chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc

Issue 2820063005: Remove the "not_after" validation of policy timestamps (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc
diff --git a/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc b/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc
index 5ede8727988b73d6db4025c9e790edc15eb27b97..adfd139b24c2c8aaf03f3358bca27547bbecb357 100644
--- a/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc
+++ b/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc
@@ -153,7 +153,7 @@ void UserCloudPolicyStoreChromeOS::ValidatePolicyForStore(
// Create and configure a validator.
std::unique_ptr<UserCloudPolicyValidator> validator = CreateValidator(
- std::move(policy), CloudPolicyValidatorBase::TIMESTAMP_FULLY_VALIDATED);
+ std::move(policy), CloudPolicyValidatorBase::TIMESTAMP_VALIDATED);
validator->ValidateUsername(account_id_.GetUserEmail(), true);
if (cached_policy_key_.empty()) {
validator->ValidateInitialKey(ExtractDomain(account_id_.GetUserEmail()));
@@ -359,11 +359,10 @@ std::unique_ptr<UserCloudPolicyValidator>
UserCloudPolicyStoreChromeOS::CreateValidatorForLoad(
std::unique_ptr<em::PolicyFetchResponse> policy) {
std::unique_ptr<UserCloudPolicyValidator> validator = CreateValidator(
- std::move(policy), CloudPolicyValidatorBase::TIMESTAMP_NOT_BEFORE);
+ std::move(policy), CloudPolicyValidatorBase::TIMESTAMP_VALIDATED);
if (is_active_directory_) {
validator->ValidateTimestamp(
- base::Time(), base::Time(),
- CloudPolicyValidatorBase::TIMESTAMP_NOT_VALIDATED);
+ base::Time(), CloudPolicyValidatorBase::TIMESTAMP_NOT_VALIDATED);
validator->ValidateDMToken(std::string(),
CloudPolicyValidatorBase::DM_TOKEN_NOT_REQUIRED);
validator->ValidateDeviceId(

Powered by Google App Engine
This is Rietveld 408576698