diagnostics: Implement PosixConsole::Read function.

diagnostics: Implement PosixConsole::Read function.

BUG=42894
TEST=enable the "Press [enter] to continue" on Posix,
     run out/Debug/chrome --diagnostics and see if it can read the line.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50208

[tfarina, 2010-06-16 00:48:44]

Hi Matt, could you review this to me?

http://codereview.chromium.org/2820009/diff/1/2
File chrome/browser/diagnostics/diagnostics_main.cc (right):

http://codereview.chromium.org/2820009/diff/1/2#newcode345
chrome/browser/diagnostics/diagnostics_main.cc:345: #if defined(OS_WIN)
Note: I tried it, with || defined(OS_LINUX) here.

[mattm, 2010-06-16 01:01:53]

http://codereview.chromium.org/2820009/diff/1/2
File chrome/browser/diagnostics/diagnostics_main.cc (right):

http://codereview.chromium.org/2820009/diff/1/2#newcode160
chrome/browser/diagnostics/diagnostics_main.cc:160: return false;
input could be empty if the user just hits enter, should check the state  (I
guess something like "return !std::cin.fail();")

[tfarina, 2010-06-16 05:47:29]

On 2010/06/16 01:01:53, mattm wrote:
> http://codereview.chromium.org/2820009/diff/1/2
> File chrome/browser/diagnostics/diagnostics_main.cc (right):
> 
> http://codereview.chromium.org/2820009/diff/1/2#newcode160
> chrome/browser/diagnostics/diagnostics_main.cc:160: return false;
> input could be empty if the user just hits enter, should check the state  (I
> guess something like "return !std::cin.fail();")

I tried a different approach, just checking the return of std::getline.

[mattm, 2010-06-16 21:36:41]

On 2010/06/16 05:47:29, tfarina wrote:
> On 2010/06/16 01:01:53, mattm wrote:
> > http://codereview.chromium.org/2820009/diff/1/2
> > File chrome/browser/diagnostics/diagnostics_main.cc (right):
> > 
> > http://codereview.chromium.org/2820009/diff/1/2#newcode160
> > chrome/browser/diagnostics/diagnostics_main.cc:160: return false;
> > input could be empty if the user just hits enter, should check the state  (I
> > guess something like "return !std::cin.fail();")
> 
> I tried a different approach, just checking the return of std::getline.


Oh yeah, forgot about the operator! on iostreams.  I guess the intention with
the cout is to advance to the next line since there wasn't an input newline to
do it?  It seems a little odd/unnecessary.

[tfarina, 2010-06-17 02:00:00]

On 2010/06/16 21:36:41, mattm wrote:
> On 2010/06/16 05:47:29, tfarina wrote:
> > On 2010/06/16 01:01:53, mattm wrote:
> > > http://codereview.chromium.org/2820009/diff/1/2
> > > File chrome/browser/diagnostics/diagnostics_main.cc (right):
> > > 
> > > http://codereview.chromium.org/2820009/diff/1/2#newcode160
> > > chrome/browser/diagnostics/diagnostics_main.cc:160: return false;
> > > input could be empty if the user just hits enter, should check the state 
(I
> > > guess something like "return !std::cin.fail();")
> > 
> > I tried a different approach, just checking the return of std::getline.
> 
> 
> Oh yeah, forgot about the operator! on iostreams.  I guess the intention with
> the cout is to advance to the next line since there wasn't an input newline to
> do it?  It seems a little odd/unnecessary.

Yeah, looking again, you are right, it's unnecessary. I removed it.

[mattm, 2010-06-17 02:15:21]

LGTM