ios/chrome/app/application_delegate/metrics_mediator.mm - Issue 2819883002: Remove usage of Tab's |url| property from MetricsMediator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/app/application_delegate/metrics_mediator.mm

Issue 2819883002: Remove usage of Tab's |url| property from MetricsMediator. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/app/application_delegate/metrics_mediator.mm

diff --git a/ios/chrome/app/application_delegate/metrics_mediator.mm b/ios/chrome/app/application_delegate/metrics_mediator.mm

index 3b5ecee6992f944fc32d8e0d68da4e658581db76..bbd4e7c08614fce978fac9342d6c025e9e0e77ac 100644

--- a/ios/chrome/app/application_delegate/metrics_mediator.mm

+++ b/ios/chrome/app/application_delegate/metrics_mediator.mm

@@ -144,7 +144,7 @@ + (void)logLaunchMetricsWithStartupInformation:

GURL ntpUrl = GURL(kChromeUINewTabURL);

Tab* currentTab = [[browserViewInformation currentTabModel] currentTab];

- if (currentTab && [currentTab url] == ntpUrl) {

+ if (currentTab.lastCommittedURL == ntpUrl) {

kkhorimoto 2017/04/14 20:28:51 These metrics are gathered at startup, so I think

startupInformation.firstUserActionRecorder->RecordStartOnNTP();

[startupInformation resetFirstUserActionRecorder];

} else {

« no previous file with comments | « no previous file | no next file » | no next file with comments »