third_party/WebKit/Source/core/dom/ModuleScript.cpp - Issue 2819733002: Implement ModuleScript::RunScript()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ModuleScript.cpp

Issue 2819733002: Implement ModuleScript::RunScript() (Closed)

Patch Set: Update comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ModuleScript.cpp

diff --git a/third_party/WebKit/Source/core/dom/ModuleScript.cpp b/third_party/WebKit/Source/core/dom/ModuleScript.cpp

index 9e2845e11cfaac2eddea279dfdb06a7ecd3826fc..a0f6a396a78fb14fe72bdbab795330f2c96185aa 100644

--- a/third_party/WebKit/Source/core/dom/ModuleScript.cpp

+++ b/third_party/WebKit/Source/core/dom/ModuleScript.cpp

@@ -58,8 +58,7 @@ bool ModuleScript::CheckMIMETypeBeforeRunScript(Document* context_document,

}

void ModuleScript::RunScript(LocalFrame* frame, const SecurityOrigin*) const {

- // TODO(hiroshige): Implement this once Modulator::ExecuteModule() is landed.

- NOTREACHED();

+ settings_object_->ExecuteModule(this);

}

String ModuleScript::InlineSourceTextForCSP() const {