chrome/browser/tether/OWNERS - Issue 2819713002: Create TetherService, a TetherAllowed pref, and use DependencyManager for RegisterProfilePrefs call…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/tether/OWNERS

Issue 2819713002: Create TetherService, a TetherAllowed pref, and use DependencyManager for RegisterProfilePrefs call… (Closed)

Patch Set: Do not explicitly call on TetherService::Shutdown() from UserSessionManager. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/chromeos/login/session/user_session_manager.cc ('K') | « chrome/browser/tether/DEPS ('k') | chrome/browser/tether/tether_service.h » ('j') | chrome/browser/tether/tether_service.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 khorimoto@chromium.org

	2 hansberry@chromium.org
	Lei Zhang 2017/04/19 19:13:17 Do you have a bug component? If so, add a COMPONEN Do you have a bug component? If so, add a COMPONENT: line? See other OWNERS file for examples. Ryan Hansberry 2017/04/20 17:22:32 We don't have a bug component. :/ Show quoted text On 2017/04/19 19:13:17, Lei Zhang wrote: > Do you have a bug component? If so, add a COMPONENT: line? See other OWNERS file > for examples. We don't have a bug component. :/ Lei Zhang 2017/04/20 19:26:21 Do you plan to? What component will people file bu Show quoted text On 2017/04/20 17:22:32, Ryan Hansberry wrote: > On 2017/04/19 19:13:17, Lei Zhang wrote: > > Do you have a bug component? If so, add a COMPONENT: line? See other OWNERS > file > > for examples. > > We don't have a bug component. :/ Do you plan to? What component will people file bugs under? You can always add COMPONENT: later. Ryan Hansberry 2017/04/20 22:08:09 Yes, we plan to. I will add a COMPONENT: line when Show quoted text On 2017/04/20 19:26:21, Lei Zhang wrote: > On 2017/04/20 17:22:32, Ryan Hansberry wrote: > > On 2017/04/19 19:13:17, Lei Zhang wrote: > > > Do you have a bug component? If so, add a COMPONENT: line? See other OWNERS > > file > > > for examples. > > > > We don't have a bug component. :/ > > Do you plan to? What component will people file bugs under? You can always add > COMPONENT: later. Yes, we plan to. I will add a COMPONENT: line when we have one.
OLD	NEW