Create TetherService, a TetherAllowed pref, and use DependencyManager for RegisterProfilePrefs call…

chrome/browser/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//build/split_static_library.gni")
 import("//chrome/common/features.gni")
@@ skipping 3557 matching lines @@
       "task_manager/sampling/task_group_sampler.cc",
       "task_manager/sampling/task_group_sampler.h",
       "task_manager/sampling/task_manager_impl.cc",
       "task_manager/sampling/task_manager_impl.h",
       "task_manager/sampling/task_manager_io_thread_helper.cc",
       "task_manager/sampling/task_manager_io_thread_helper.h",
       "task_manager/task_manager_interface.cc",
       "task_manager/task_manager_interface.h",
       "task_manager/task_manager_observer.cc",
       "task_manager/task_manager_observer.h",
+      "tether/tether_service.cc",

[Lei Zhang, 2017/04/19 19:13:17]

Is this going to build on Windows/Mac/Linux too? You should run some try jobs
when you get closer to be able to submit.

[Ryan Hansberry, 2017/04/20 17:22:32]

This is only intended to run on ChromeOS.

[Lei Zhang, 2017/04/20 19:17:14]

So why is not in a ChromeOS only source list? (see line 3199 where this section
starts)

[Lei Zhang, 2017/04/20 19:24:30]

Another question - is this ever going to be used on Windows/Mac/Linux? If not,
you can leave it here, but rename the files to have the _chromeos postfix. e.g.
tether/tether_service_chromeos.cc. Then it won't be built on other platforms.

[Ryan Hansberry, 2017/04/20 22:08:09]

I've moved these under a is_chromeos source list. Let me know if that's
incorrect (And there are no plans to expand this to platforms other than
ChromeOS).

[Lei Zhang, 2017/04/20 22:11:43]

Why not just rename the file so it is immediately obvious that the file is
platform specific?

[Ryan Hansberry, 2017/04/20 22:26:45]

What's the preferred situation:

1) Place tether_service_* under the non-Android source set it was with the
suffix _chromeos
2) Place tether_service_* under this is_chromeos source set without the suffix
_chromeos
3) Place tether_service_* under this is_chromeos source set and use the suffix
_chromeos
4) Place tether_service_* files under chrome/browser/chromeos

?

+      "tether/tether_service.h",
+      "tether/tether_service_factory.cc",
+      "tether/tether_service_factory.h",
       "themes/browser_theme_pack.cc",
       "themes/browser_theme_pack.h",
       "themes/custom_theme_supplier.cc",
       "themes/custom_theme_supplier.h",
       "themes/theme_properties.cc",
       "themes/theme_service.cc",
       "themes/theme_service.h",
       "themes/theme_service_factory.cc",
       "themes/theme_service_factory.h",
       "themes/theme_service_mac.mm",
@@ skipping 1103 matching lines @@
       "media/pepper_cdm_test_constants.cc",
       "media/pepper_cdm_test_constants.h",
     ]
   }
 }
 
 service_manifest("preferences_forwarder_manifest") {
   name = "preferences_forwarder"
   source = "prefs/forwarder_manifest.json"
 }