Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: extensions/renderer/api_request_handler_unittest.cc

Issue 2819683002: [Extenisons Bindings] Don't throw unchecked errors; add console errors (Closed)
Patch Set: jbroman's Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/api_last_error_unittest.cc ('k') | extensions/renderer/console.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_request_handler_unittest.cc
diff --git a/extensions/renderer/api_request_handler_unittest.cc b/extensions/renderer/api_request_handler_unittest.cc
index cbf9e5377957667ecbe324f357af69004903be61..f40527b7014b6ca3affbe6fddba4ae6e90e885f2 100644
--- a/extensions/renderer/api_request_handler_unittest.cc
+++ b/extensions/renderer/api_request_handler_unittest.cc
@@ -67,7 +67,7 @@ TEST_F(APIRequestHandlerTest, AddRequestAndCompleteRequestTest) {
APIRequestHandler request_handler(
base::Bind(&DoNothingWithRequest),
base::Bind(&APIRequestHandlerTest::RunJS, base::Unretained(this)),
- APILastError(APILastError::GetParent()));
+ APILastError(APILastError::GetParent(), APILastError::AddConsoleError()));
EXPECT_TRUE(request_handler.GetPendingRequestIdsForTesting().empty());
@@ -102,7 +102,7 @@ TEST_F(APIRequestHandlerTest, InvalidRequestsTest) {
APIRequestHandler request_handler(
base::Bind(&DoNothingWithRequest),
base::Bind(&APIRequestHandlerTest::RunJS, base::Unretained(this)),
- APILastError(APILastError::GetParent()));
+ APILastError(APILastError::GetParent(), APILastError::AddConsoleError()));
v8::Local<v8::Function> function = FunctionFromString(context, kEchoArgs);
ASSERT_FALSE(function.IsEmpty());
@@ -138,7 +138,7 @@ TEST_F(APIRequestHandlerTest, MultipleRequestsAndContexts) {
APIRequestHandler request_handler(
base::Bind(&DoNothingWithRequest),
base::Bind(&APIRequestHandlerTest::RunJS, base::Unretained(this)),
- APILastError(APILastError::GetParent()));
+ APILastError(APILastError::GetParent(), APILastError::AddConsoleError()));
// By having both different arguments and different behaviors in the
// callbacks, we can easily verify that the right function is called in the
@@ -190,7 +190,7 @@ TEST_F(APIRequestHandlerTest, CustomCallbackArguments) {
APIRequestHandler request_handler(
base::Bind(&DoNothingWithRequest),
base::Bind(&APIRequestHandlerTest::RunJS, base::Unretained(this)),
- APILastError(APILastError::GetParent()));
+ APILastError(APILastError::GetParent(), APILastError::AddConsoleError()));
v8::Local<v8::Function> custom_callback =
FunctionFromString(context, kEchoArgs);
@@ -237,7 +237,7 @@ TEST_F(APIRequestHandlerTest, CustomCallbackArgumentsWithEmptyCallback) {
APIRequestHandler request_handler(
base::Bind(&DoNothingWithRequest),
base::Bind(&APIRequestHandlerTest::RunJS, base::Unretained(this)),
- APILastError(APILastError::GetParent()));
+ APILastError(APILastError::GetParent(), APILastError::AddConsoleError()));
v8::Local<v8::Function> custom_callback =
FunctionFromString(context, kEchoArgs);
@@ -275,7 +275,7 @@ TEST_F(APIRequestHandlerTest, UserGestureTest) {
APIRequestHandler request_handler(
base::Bind(&DoNothingWithRequest),
base::Bind(&APIRequestHandlerTest::RunJS, base::Unretained(this)),
- APILastError(APILastError::GetParent()));
+ APILastError(APILastError::GetParent(), APILastError::AddConsoleError()));
auto callback = [](base::Optional<bool>* ran_with_user_gesture) {
*ran_with_user_gesture =
@@ -339,7 +339,7 @@ TEST_F(APIRequestHandlerTest, RequestThread) {
APIRequestHandler request_handler(
base::Bind(on_request, &thread),
base::Bind(&APIRequestHandlerTest::RunJS, base::Unretained(this)),
- APILastError(APILastError::GetParent()));
+ APILastError(APILastError::GetParent(), APILastError::AddConsoleError()));
request_handler.StartRequest(
context, kMethod, base::MakeUnique<base::ListValue>(),
« no previous file with comments | « extensions/renderer/api_last_error_unittest.cc ('k') | extensions/renderer/console.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698