extensions/renderer/api_binding_unittest.cc - Issue 2819683002: [Extenisons Bindings] Don't throw unchecked errors; add console errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api_binding_unittest.cc

Issue 2819683002: [Extenisons Bindings] Don't throw unchecked errors; add console errors (Closed)

Patch Set: jbroman's Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/api_binding_unittest.cc

diff --git a/extensions/renderer/api_binding_unittest.cc b/extensions/renderer/api_binding_unittest.cc

index c8d7d22515d9f401d00cf81d8e7150571ab86708..770780283c202e461b2cb51db0033c59ac9751d6 100644

--- a/extensions/renderer/api_binding_unittest.cc

+++ b/extensions/renderer/api_binding_unittest.cc

@@ -143,7 +143,8 @@ class APIBindingUnittest : public APIBindingTest {

request_handler_ = base::MakeUnique<APIRequestHandler>(

base::Bind(&APIBindingUnittest::OnFunctionCall, base::Unretained(this)),

base::Bind(&RunFunctionOnGlobalAndIgnoreResult),

- APILastError(APILastError::GetParent()));

+ APILastError(APILastError::GetParent(),

+ APILastError::AddConsoleError()));

}

void TearDown() override {