[Extenisons Bindings] Don't throw unchecked errors; add console errors

extensions/renderer/console.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/console.h"
 
 #include "base/compiler_specific.h"
 #include "base/debug/alias.h"
 #include "base/lazy_instance.h"
 #include "base/macros.h"
@@ skipping 36 matching lines @@
   // A worker's ScriptContext neither lives in ScriptContextSet nor it has a
   // RenderFrame associated with it, so early exit in this case.
   // TODO(lazyboy): Fix.
   if (content::WorkerThread::GetCurrentId() > 0)
     return;
 
   v8::Local<v8::Context> context = info.GetIsolate()->GetCurrentContext();
   ScriptContext* script_context =
       ScriptContextSet::GetContextByV8Context(context);
   // TODO(devlin): Consider (D)CHECK(script_context)
-  content::RenderFrame* render_frame =
-      script_context ? script_context->GetRenderFrame() : nullptr;
   const auto level = static_cast<content::ConsoleMessageLevel>(
       info.Data().As<v8::Int32>()->Value());
-  AddMessage(render_frame, level, message);
+  AddMessage(script_context, level, message);
 }
 
 gin::WrapperInfo kWrapperInfo = {gin::kEmbedderNativeGin};
 
 }  // namespace
 
-void Fatal(content::RenderFrame* render_frame, const std::string& message) {
-  AddMessage(render_frame, content::CONSOLE_MESSAGE_LEVEL_ERROR, message);
+void Fatal(ScriptContext* context, const std::string& message) {
+  AddMessage(context, content::CONSOLE_MESSAGE_LEVEL_ERROR, message);
   CheckWithMinidump(message);
 }
 
-void AddMessage(content::RenderFrame* render_frame,
+void AddMessage(ScriptContext* script_context,
                 content::ConsoleMessageLevel level,
                 const std::string& message) {
+  if (!script_context) {
+    LOG(WARNING) << "Could not log \"" << message
+                 << "\": no ScriptContext found";
+    return;
+  }
+  content::RenderFrame* render_frame = script_context->GetRenderFrame();
   if (!render_frame) {
+    // TODO(lazyboy/devlin): This can happen when this is the context for a
+    // service worker. blink::WebEmbeddedWorker has an AddMessageToConsole
+    // method that we could theoretically hook into.
     LOG(WARNING) << "Could not log \"" << message
                  << "\": no render frame found";
-  } else {
-    render_frame->AddMessageToConsole(level, message);
+    return;
   }
+
+  render_frame->AddMessageToConsole(level, message);
 }
 
 v8::Local<v8::Object> AsV8Object(v8::Isolate* isolate) {
   v8::EscapableHandleScope handle_scope(isolate);
   gin::PerIsolateData* data = gin::PerIsolateData::From(isolate);
   v8::Local<v8::ObjectTemplate> templ = data->GetObjectTemplate(&kWrapperInfo);
   if (templ.IsEmpty()) {
     templ = v8::ObjectTemplate::New(isolate);
     static const struct {
       const char* name;
@@ skipping 12 matching lines @@
       templ->Set(gin::StringToSymbol(isolate, method.name), function);
     }
     data->SetObjectTemplate(&kWrapperInfo, templ);
   }
   return handle_scope.Escape(
       templ->NewInstance(isolate->GetCurrentContext()).ToLocalChecked());
 }
 
 }  // namespace console
 }  // namespace extensions