[Extenisons Bindings] Don't throw unchecked errors; add console errors

extensions/renderer/api_last_error.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/api_last_error.h"
 
 #include "gin/converter.h"
 #include "gin/handle.h"
 #include "gin/object_template_builder.h"
 #include "gin/wrappable.h"
@@ skipping 35 matching lines @@
   std::string error_;
   bool accessed_ = false;
 
   DISALLOW_COPY_AND_ASSIGN(LastErrorObject);
 };
 
 gin::WrapperInfo LastErrorObject::kWrapperInfo = {gin::kEmbedderNativeGin};
 
 }  // namespace
 
-APILastError::APILastError(const GetParent& get_parent)
-    : get_parent_(get_parent) {}
+APILastError::APILastError(const GetParent& get_parent,
+                           const AddConsoleError& add_console_error)
+    : get_parent_(get_parent), add_console_error_(add_console_error) {}
 APILastError::APILastError(APILastError&& other) = default;
 APILastError::~APILastError() = default;
 
 void APILastError::SetError(v8::Local<v8::Context> context,
                             const std::string& error) {
   v8::Isolate* isolate = context->GetIsolate();
   DCHECK(isolate);
   v8::HandleScope handle_scope(isolate);
 
   // The various accesses/sets on an object could potentially fail if script has
@@ skipping 58 matching lines @@
     v8::Local<v8::Value> error;
     if (!parent->Get(context, key).ToLocal(&error))
       return;
     if (!gin::Converter<LastErrorObject*>::FromV8(context->GetIsolate(), error,
                                                   &last_error)) {
       return;
     }
   }
 
   if (report_if_unchecked && !last_error->accessed()) {
-    isolate->ThrowException(
-        v8::Exception::Error(gin::StringToV8(isolate, last_error->error())));
+    add_console_error_.Run(
+        context, "Unchecked runtime.lastError: " + last_error->error());
   }
 
   // See comment in SetError().
   v8::TryCatch try_catch(isolate);
   try_catch.SetVerbose(true);
 
   // This Delete() can fail, but there's nothing to do if it does (the exception
   // will be caught by the TryCatch above).
   parent->Delete(context, key).ToChecked();
 }
@@ skipping 14 matching lines @@
            .ToLocal(&error)) {
     return false;
   }
 
   LastErrorObject* last_error = nullptr;
   return gin::Converter<LastErrorObject*>::FromV8(context->GetIsolate(), error,
                                                   &last_error);
 }
 
 }  // namespace extensions