[Extenisons Bindings] Don't throw unchecked errors; add console errors

extensions/renderer/api_request_handler_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/api_request_handler.h"
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
 #include "base/optional.h"
 #include "base/values.h"
 #include "extensions/renderer/api_binding_test.h"
@@ skipping 49 matching lines @@
 
 // Tests adding a request to the request handler, and then triggering the
 // response.
 TEST_F(APIRequestHandlerTest, AddRequestAndCompleteRequestTest) {
   v8::HandleScope handle_scope(isolate());
   v8::Local<v8::Context> context = MainContext();
 
   APIRequestHandler request_handler(
       base::Bind(&DoNothingWithRequest),
       base::Bind(&APIRequestHandlerTest::RunJS, base::Unretained(this)),
-      APILastError(APILastError::GetParent()));
+      APILastError(APILastError::GetParent(), APILastError::AddConsoleError()));
 
   EXPECT_TRUE(request_handler.GetPendingRequestIdsForTesting().empty());
 
   v8::Local<v8::Function> function = FunctionFromString(context, kEchoArgs);
   ASSERT_FALSE(function.IsEmpty());
 
   int request_id = request_handler.StartRequest(
       context, kMethod, base::MakeUnique<base::ListValue>(), function,
       v8::Local<v8::Function>(), binding::RequestThread::UI);
   EXPECT_THAT(request_handler.GetPendingRequestIdsForTesting(),
@@ skipping 14 matching lines @@
 }
 
 // Tests that trying to run non-existent or invalided requests is a no-op.
 TEST_F(APIRequestHandlerTest, InvalidRequestsTest) {
   v8::HandleScope handle_scope(isolate());
   v8::Local<v8::Context> context = MainContext();
 
   APIRequestHandler request_handler(
       base::Bind(&DoNothingWithRequest),
       base::Bind(&APIRequestHandlerTest::RunJS, base::Unretained(this)),
-      APILastError(APILastError::GetParent()));
+      APILastError(APILastError::GetParent(), APILastError::AddConsoleError()));
 
   v8::Local<v8::Function> function = FunctionFromString(context, kEchoArgs);
   ASSERT_FALSE(function.IsEmpty());
 
   int request_id = request_handler.StartRequest(
       context, kMethod, base::MakeUnique<base::ListValue>(), function,
       v8::Local<v8::Function>(), binding::RequestThread::UI);
   EXPECT_THAT(request_handler.GetPendingRequestIdsForTesting(),
               testing::UnorderedElementsAre(request_id));
 
@@ skipping 15 matching lines @@
 }
 
 TEST_F(APIRequestHandlerTest, MultipleRequestsAndContexts) {
   v8::HandleScope handle_scope(isolate());
   v8::Local<v8::Context> context_a = MainContext();
   v8::Local<v8::Context> context_b = AddContext();
 
   APIRequestHandler request_handler(
       base::Bind(&DoNothingWithRequest),
       base::Bind(&APIRequestHandlerTest::RunJS, base::Unretained(this)),
-      APILastError(APILastError::GetParent()));
+      APILastError(APILastError::GetParent(), APILastError::AddConsoleError()));
 
   // By having both different arguments and different behaviors in the
   // callbacks, we can easily verify that the right function is called in the
   // right context.
   v8::Local<v8::Function> function_a = FunctionFromString(
       context_a, "(function(res) { this.result = res + 'alpha'; })");
   v8::Local<v8::Function> function_b = FunctionFromString(
       context_b, "(function(res) { this.result = res + 'beta'; })");
 
   int request_a = request_handler.StartRequest(
@@ skipping 31 matching lines @@
       GetStringPropertyFromObject(context_b->Global(), context_b, "result"));
 }
 
 TEST_F(APIRequestHandlerTest, CustomCallbackArguments) {
   v8::HandleScope handle_scope(isolate());
   v8::Local<v8::Context> context = MainContext();
 
   APIRequestHandler request_handler(
       base::Bind(&DoNothingWithRequest),
       base::Bind(&APIRequestHandlerTest::RunJS, base::Unretained(this)),
-      APILastError(APILastError::GetParent()));
+      APILastError(APILastError::GetParent(), APILastError::AddConsoleError()));
 
   v8::Local<v8::Function> custom_callback =
       FunctionFromString(context, kEchoArgs);
   v8::Local<v8::Function> callback =
       FunctionFromString(context, "(function() {})");
   ASSERT_FALSE(callback.IsEmpty());
   ASSERT_FALSE(custom_callback.IsEmpty());
 
   int request_id = request_handler.StartRequest(
       context, "method", base::MakeUnique<base::ListValue>(), callback,
@@ skipping 26 matching lines @@
 
 // Test that having a custom callback without an extension-provided callback
 // doesn't crash.
 TEST_F(APIRequestHandlerTest, CustomCallbackArgumentsWithEmptyCallback) {
   v8::HandleScope handle_scope(isolate());
   v8::Local<v8::Context> context = MainContext();
 
   APIRequestHandler request_handler(
       base::Bind(&DoNothingWithRequest),
       base::Bind(&APIRequestHandlerTest::RunJS, base::Unretained(this)),
-      APILastError(APILastError::GetParent()));
+      APILastError(APILastError::GetParent(), APILastError::AddConsoleError()));
 
   v8::Local<v8::Function> custom_callback =
       FunctionFromString(context, kEchoArgs);
   ASSERT_FALSE(custom_callback.IsEmpty());
 
   v8::Local<v8::Function> empty_callback;
   int request_id = request_handler.StartRequest(
       context, "method", base::MakeUnique<base::ListValue>(), empty_callback,
       custom_callback, binding::RequestThread::UI);
   EXPECT_THAT(request_handler.GetPendingRequestIdsForTesting(),
@@ skipping 17 matching lines @@
 }
 
 // Test user gestures being curried around for API requests.
 TEST_F(APIRequestHandlerTest, UserGestureTest) {
   v8::HandleScope handle_scope(isolate());
   v8::Local<v8::Context> context = MainContext();
 
   APIRequestHandler request_handler(
       base::Bind(&DoNothingWithRequest),
       base::Bind(&APIRequestHandlerTest::RunJS, base::Unretained(this)),
-      APILastError(APILastError::GetParent()));
+      APILastError(APILastError::GetParent(), APILastError::AddConsoleError()));
 
   auto callback = [](base::Optional<bool>* ran_with_user_gesture) {
     *ran_with_user_gesture =
         blink::WebUserGestureIndicator::IsProcessingUserGestureThreadSafe();
   };
 
   // Set up a callback to be used with the request so we can check if a user
   // gesture was active.
   base::Optional<bool> ran_with_user_gesture;
   v8::Local<v8::FunctionTemplate> function_template =
@@ skipping 43 matching lines @@
   base::Optional<binding::RequestThread> thread;
   auto on_request = [](base::Optional<binding::RequestThread>* thread_out,
                        std::unique_ptr<APIRequestHandler::Request> request,
                        v8::Local<v8::Context> context) {
     *thread_out = request->thread;
   };
 
   APIRequestHandler request_handler(
       base::Bind(on_request, &thread),
       base::Bind(&APIRequestHandlerTest::RunJS, base::Unretained(this)),
-      APILastError(APILastError::GetParent()));
+      APILastError(APILastError::GetParent(), APILastError::AddConsoleError()));
 
   request_handler.StartRequest(
       context, kMethod, base::MakeUnique<base::ListValue>(),
       v8::Local<v8::Function>(), v8::Local<v8::Function>(),
       binding::RequestThread::UI);
   ASSERT_TRUE(thread);
   EXPECT_EQ(binding::RequestThread::UI, *thread);
   thread.reset();
 
   request_handler.StartRequest(
       context, kMethod, base::MakeUnique<base::ListValue>(),
       v8::Local<v8::Function>(), v8::Local<v8::Function>(),
       binding::RequestThread::IO);
   ASSERT_TRUE(thread);
   EXPECT_EQ(binding::RequestThread::IO, *thread);
   thread.reset();
 }
 
 }  // namespace extensions