Cleanup Tool WebUI: Add functionality to the Cleanup button

chrome/browser/safe_browsing/srt_fetcher_win.h

Index: chrome/browser/safe_browsing/srt_fetcher_win.h
diff --git a/chrome/browser/safe_browsing/srt_fetcher_win.h b/chrome/browser/safe_browsing/srt_fetcher_win.h
index a6e79e1aecec608e1bc7af8e9cc6394d522fe37d..22460809080c529c52741d1bc4203c4fb5789b73 100644
--- a/chrome/browser/safe_browsing/srt_fetcher_win.h
+++ b/chrome/browser/safe_browsing/srt_fetcher_win.h
@@ -11,6 +11,7 @@
 #include <queue>
 #include <string>
 
+#include "base//callback.h"

[alito, 2017/04/14 00:01:18]

Remove the extra '/'

[proberge, 2017/04/18 19:24:28]

Wow, no idea what happened there.

 #include "base/command_line.h"
 #include "base/feature_list.h"
 #include "base/process/launch.h"
@@ -148,6 +149,9 @@ void SetSwReporterTestingDelegate(SwReporterTestingDelegate* delegate);
 
 void DisplaySRTPromptForTesting(const base::FilePath& download_path);
 
+// Called by chrome://cleanup/ to manually trigger a cleaner run.
+void DisplayUserInitiatedSRTPromptDialog(base::Closure callback);

[alito, 2017/04/14 00:01:18]

In order for the organic page to be able to run the cleaner, it will need to
call some modified version of the RunSwReporters() function (The cleaner needs
to run, the IPC will have to be set up, and the info passed from the cleaner to
Chrome needs to eventually make its way to the SRTPromptController). It's still
more complicated because we need to ensure that there is one place where all
requests for running the cleaner comes in so we don't run it multiple times
resulting in multiple prompts.

How about holding off on displaying the prompt from the organic page for now? Or
if you want to just prototype the dialog being displayed, move this function to
cleanup_action_handler.cc until we are ready to hook everything up?

[proberge, 2017/04/18 19:24:28]

Scan results will need to be available before "Run Chrome Cleanup" is displayed.
I don't think we want to run the scan again; we should have all the information
needed to show the prompt. 

The user can initiate a scan by clicking on the "Scan Now" button on this page.
See https://codereview.chromium.org/2822433003/.

I would prefer to keep logic out of ui/webui. 

[alito, 2017/04/19 18:01:44]

As we discussed offline, the logic could be simplified so that whenever any
"scan" or "clean" button is clicked on the webui, the full cleaner flow would be
run. That way we wouldn't need to cache the results of scans and we would ensure
that the information displayed in the prompt is accurate wrt files that will be
removed.

[proberge, 2017/04/19 18:03:10]

Ack, closing this CL. 

[proberge, 2017/04/25 17:51:09]

Re-opening since it seems that we will indeed have "Start Cleaning" logic on
this WebUI. 

+
 }  // namespace safe_browsing
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_SRT_FETCHER_WIN_H_