Cleanup Tool WebUI: Add functionality to the Cleanup button

chrome/browser/resources/cleanup_tool/manager.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 Polymer({
   is: 'cleanup-manager',
 
   properties: {
     hasScanResults: {
       type: Boolean,
       value: false,
     },
 
     isInfected: {
       type: Boolean,
       value: false,
     },
 
-    isRunningScanner: {
+    isRunning: {
       type: Boolean,
       value: false,
     },
 
     detectionStatusText: {
       type: String,
       value: ""
     },
 
     detectionTimeText: {
@@ skipping 22 matching lines @@
    */
   onScanTap_: function() {
     // TODO implement me.
   },
 
   /**
    * Sends a request for Chrome to open the Cleanup Tool's cleanup prompt.
    * @private
    */
   onCleanupTap_: function() {
-    // TODO implement me.
+    this.isRunning = true;
+    this.browserProxy_.startCleanup().then(this.onCleanupResult_.bind(this));
   },
 
   /**
+   * @param {CleanupResult} cleanupResults
+   */
+  onCleanupResult_: function(cleanupResults) {
+    this.isRunning= false;

[alito, 2017/04/14 00:01:18]

nit: space before '='

[proberge, 2017/04/18 19:24:28]

Done.

+    if (!cleanupResults.wasCancelled)
+      this.isInfected = false;

[alito, 2017/04/14 00:01:18]

Could you document why isInfected is set to false here?

[proberge, 2017/04/18 19:24:28]

Done.

+
+    // TODO(proberge): Do something about cleanupResults.uwsRemoved.
+  },
+
+  /**
    * @param {boolean} hasScanResults
    * @param {boolean} isInfected
    * @return {string} A class name for icon-specific styling.
    * @private
    */
   getIconClassName_: function(hasScanResults, isInfected) {
     return hasScanResults && isInfected ? "infected-icon" : "clean-icon";
   },
 
   /**
    * @param {boolean} hasScanResults
    * @param {boolean} isInfected
    * @return {string} An icon id. See icons.html.
    * @private
    */
   getStatusIcon_: function(hasScanResults, isInfected) {
     return hasScanResults && isInfected ?
         "cleanup:infected-user" :
         "cleanup:verified-user";
   },
 
   /**
    * @param {boolean} hasScanResults
-   * @param {boolean} isRunningScanner
-   * @return {boolean} True if the "Scan" button should be displayed, false
-   *     otherwise.
+   * @param {boolean} isRunning
+   * @return {boolean} Whether the "Scan" button should be displayed.
    * @private
    */
-  shouldShowScan_: function(hasScanResults, isRunningScanner) {
-    return !hasScanResults && !isRunningScanner;
+  shouldShowScan_: function(hasScanResults, isRunning) {
+    return !hasScanResults && !isRunning;
   },
 
   /**
+   * @param {boolean} hasScanResults
+   * @param {boolean} isRunning
+   * @return {boolean} Whether the "Run Chrome Cleanup" button should be
+   *     displayed.
+   * @private
+   */
+  shouldShowClean_: function(hasScanResults, isRunning) {
+    return hasScanResults && !isRunning;
+  },
+
+  /**
+   * @param {boolean} hasScanResults
+   * @param {boolean} isRunning
+   * @return {boolean} True if the "Scanning" label should be displayed.

[alito, 2017/04/14 00:01:18]

nit: True if -> Whether

[proberge, 2017/04/18 19:24:28]

Done.

+   * @private
+   */
+  shouldShowScanning_: function(hasScanResults, isRunning) {
+    return !hasScanResults && isRunning;
+  },
+
+  /**
+   * @param {boolean} hasScanResults
+   * @param {boolean} isRunning
+   * @return {boolean} True if the "Cleaning" label should be displayed.

[alito, 2017/04/14 00:01:18]

nit: True if -> Whether

[proberge, 2017/04/18 19:24:28]

Done.

+   * @private
+   */
+  shouldShowCleaning_: function(hasScanResults, isRunning) {
+    return hasScanResults && isRunning;
+  },
+
+  /**
    * Requests the latest Chrome Cleanup Tool scan results from Chrome, then
    * updates the local state with the new information.
    * @private
    */
   requestLastScanResult_: function() {
     this.browserProxy_.requestLastScanResult().then(
         this.updateLastScanState_.bind(this));
   },
 
   /**
    @param {LastScanResult} lastScanResults
   */
   updateLastScanState_: function(lastScanResults) {
     this.hasScanResults = lastScanResults.hasScanResults;
     this.isInfected = lastScanResults.hasScanResults;
     this.detectionStatusText = lastScanResults.detectionStatusText;
     this.detectionTimeText = lastScanResults.detectionTimeText;
   }
 });