Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc

Issue 2819633002: Restored Pre-Harmony Bubble title margin metrics (Closed)
Patch Set: Fixed a typo Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc
diff --git a/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc b/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc
index c6b846375c8c49251f2fff3a71109d13982d9300..7e573535796fbef7922a87a3d51bce045a9ccf7f 100644
--- a/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc
+++ b/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc
@@ -9,6 +9,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/test/test_browser_dialog.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/passwords/account_chooser_dialog_view.h"
#include "chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.h"
@@ -137,10 +138,11 @@ TestManagePasswordsUIController::CreateAutoSigninPrompt(
return current_autosignin_prompt_;
}
-class PasswordDialogViewTest : public InProcessBrowserTest {
+class PasswordDialogViewTest : public DialogBrowserTest {
public:
- // InProcessBrowserTest:
+ // DialogBrowserTest:
void SetUpOnMainThread() override;
+ void ShowDialog(const std::string& name) override;
void SetupChooseCredentials(
std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials,
@@ -211,7 +213,7 @@ IN_PROC_BROWSER_TEST_F(PasswordDialogViewTest,
local_credentials.push_back(base::MakeUnique<autofill::PasswordForm>(form));
GURL icon_url("https://google.com/icon.png");
form.icon_url = icon_url;
- form.display_name = base::ASCIIToUTF16("Peter Pen");
+ form.display_name = base::ASCIIToUTF16("Peter Pan");
form.federation_origin = url::Origin(GURL("https://google.com/federation"));
local_credentials.push_back(base::MakeUnique<autofill::PasswordForm>(form));
@@ -247,7 +249,7 @@ IN_PROC_BROWSER_TEST_F(
local_credentials.push_back(base::MakeUnique<autofill::PasswordForm>(form));
GURL icon_url("https://google.com/icon.png");
form.icon_url = icon_url;
- form.display_name = base::ASCIIToUTF16("Peter Pen");
+ form.display_name = base::ASCIIToUTF16("Peter Pan");
form.federation_origin = url::Origin(GURL("https://google.com/federation"));
local_credentials.push_back(base::MakeUnique<autofill::PasswordForm>(form));
@@ -465,4 +467,29 @@ IN_PROC_BROWSER_TEST_F(PasswordDialogViewTest,
ASSERT_TRUE(controller()->current_autosignin_prompt());
}
+// DialogBrowserTest methods for interactive dialog invocation.
+void PasswordDialogViewTest::ShowDialog(const std::string& name) {
+ GURL origin("https://example.com");
+ EXPECT_EQ("PopupAutoSigninPrompt", name);
+ std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials;
+ autofill::PasswordForm form;
+ form.origin = origin;
+ form.display_name = base::ASCIIToUTF16("Peter");
+ form.username_value = base::ASCIIToUTF16("peter@pan.test");
+ form.icon_url = GURL("broken url");
+ local_credentials.push_back(base::MakeUnique<autofill::PasswordForm>(form));
+ GURL icon_url("https://google.com/icon.png");
+ form.icon_url = icon_url;
+ form.display_name = base::ASCIIToUTF16("Peter Pan");
+ form.federation_origin = url::Origin(GURL("https://google.com/federation"));
+ local_credentials.push_back(base::MakeUnique<autofill::PasswordForm>(form));
+ SetupChooseCredentials(std::move(local_credentials), origin);
+ ASSERT_TRUE(controller()->current_account_chooser());
+}
+
+IN_PROC_BROWSER_TEST_F(PasswordDialogViewTest,
+ InvokeDialog_PopupAutoSigninPrompt) {
+ RunDialog();
+}
+
} // namespace

Powered by Google App Engine
This is Rietveld 408576698