Restored Pre-Harmony Bubble title margin metrics

chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/test/test_browser_dialog.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "chrome/browser/ui/views/passwords/account_chooser_dialog_view.h"
 #include "chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/password_manager/core/browser/password_bubble_experiment.h"
 #include "components/password_manager/core/common/password_manager_pref_names.h"
 #include "components/prefs/pref_service.h"
 #include "net/url_request/test_url_fetcher_factory.h"
 #include "testing/gmock/include/gmock/gmock.h"
@@ skipping 108 matching lines @@
 }
 
 AutoSigninFirstRunPrompt*
 TestManagePasswordsUIController::CreateAutoSigninPrompt(
     PasswordDialogController* controller) {
   current_autosignin_prompt_ =
       ManagePasswordsUIController::CreateAutoSigninPrompt(controller);
   return current_autosignin_prompt_;
 }
 
-class PasswordDialogViewTest : public InProcessBrowserTest {
+class PasswordDialogViewTest : public DialogBrowserTest {
  public:
   // InProcessBrowserTest:
   void SetUpOnMainThread() override;

[Peter Kasting, 2017/04/17 19:53:36]

Nit: Combine these two override blocks, since you no longer subclass this class
directly:

  // DialogBrowserTest:
  void SetUpOnMainThread() override;
  void ShowDialog(const std::string& name) override;

 
+  // DialogBrowserTest:
+  void ShowDialog(const std::string& name) override;
+
   void SetupChooseCredentials(
       std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials,
       const GURL& origin);
 
   content::WebContents* SetupTabWithTestController(Browser* browser);
 
   TestManagePasswordsUIController* controller() const { return controller_; }
 
   ChromePasswordManagerClient* client() const {
     return ChromePasswordManagerClient::FromWebContents(
@@ skipping 303 matching lines @@
   browser()->profile()->GetPrefs()->SetBoolean(
       password_manager::prefs::kCredentialsEnableAutosignin, true);
 
   // Successful login with the same form after block will prompt:
   blocked_form.reset(new autofill::PasswordForm(form));
   client()->NotifyUserCouldBeAutoSignedIn(std::move(blocked_form));
   client()->NotifySuccessfulLoginWithExistingPassword(form);
   ASSERT_TRUE(controller()->current_autosignin_prompt());
 }
 
+// DialogBrowserTest methods for interactive dialog invocation
+void PasswordDialogViewTest::ShowDialog(const std::string& name) {
+  GURL origin("https://example.com");
+  std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials;
+  autofill::PasswordForm form;
+  form.origin = origin;
+  form.display_name = base::ASCIIToUTF16("Peter");
+  form.username_value = base::ASCIIToUTF16("peter@pan.test");
+  form.icon_url = GURL("broken url");
+  local_credentials.push_back(base::MakeUnique<autofill::PasswordForm>(form));

[Peter Kasting, 2017/04/17 19:53:36]

Nit: Having to construct on the static and then copy-construct on the heap seems
really lame.  Can we add an n-arg constructor to PasswordForm so this can become
something like this?:

  std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials = {
    base::MakeUnique<autofill::PasswordForm>(...),
    base::MakeUnique<autofill::PasswordForm>(...),
  };

It seems like there are other places in this file that could benefit too.

This could be done as a separate change.

[kylix_rd, 2017/04/18 16:05:16]

That makes sense. I do, however, approach it from the angle that this code is
clearly working since it based on existing code within this same file. In a
"Hippocratic" sense, I'm not doing any harm with this code.
I'll add it to the list :)

+  GURL icon_url("https://google.com/icon.png");
+  form.icon_url = icon_url;
+  form.display_name = base::ASCIIToUTF16("Peter Pen");
+  form.federation_origin = url::Origin(GURL("https://google.com/federation"));
+  local_credentials.push_back(base::MakeUnique<autofill::PasswordForm>(form));
+  SetupChooseCredentials(std::move(local_credentials), origin);
+  ASSERT_TRUE(controller()->current_account_chooser());
+}
+
+IN_PROC_BROWSER_TEST_F(PasswordDialogViewTest,
+                       InvokeDialog_PopupAutoSigninPrompt) {
+  RunDialog();
+}
+
 }  // namespace