Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: chrome/browser/autofill/autofill_interactive_uitest.cc

Issue 2819553002: Disable AutofillInteractiveTest.OnSelectOptionFromDatalist on Windows and Linux (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/files/file_util.h" 8 #include "base/files/file_util.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 746 matching lines...) Expand 10 before | Expand all | Expand 10 after
757 // Invoke and accept the Autofill popup and verify the field was filled. 757 // Invoke and accept the Autofill popup and verify the field was filled.
758 SendKeyToPageAndWait(ui::DomKey::FromCharacter('M'), ui::DomCode::US_M, 758 SendKeyToPageAndWait(ui::DomKey::FromCharacter('M'), ui::DomCode::US_M,
759 ui::VKEY_M); 759 ui::VKEY_M);
760 SendKeyToPopupAndWait(ui::DomKey::ARROW_DOWN); 760 SendKeyToPopupAndWait(ui::DomKey::ARROW_DOWN);
761 SendKeyToPopupAndWait(ui::DomKey::ENTER); 761 SendKeyToPopupAndWait(ui::DomKey::ENTER);
762 ExpectFieldValue("firstname", "Milton"); 762 ExpectFieldValue("firstname", "Milton");
763 } 763 }
764 764
765 // Test that an input field is not rendered with the yellow autofilled 765 // Test that an input field is not rendered with the yellow autofilled
766 // background color when choosing an option from the datalist suggestion list. 766 // background color when choosing an option from the datalist suggestion list.
767 #if defined(OS_MACOSX) || defined(OS_CHROMEOS) 767 #if defined(OS_MACOSX) || defined(OS_CHROMEOS) || defined(OS_WIN) || \
768 defined(OS_LINUX)
768 // Flakily triggers and assert on Mac; flakily gets empty string instead 769 // Flakily triggers and assert on Mac; flakily gets empty string instead
769 // of "Adam" on ChromeOS. 770 // of "Adam" on ChromeOS.
770 // http://crbug.com/419868, http://crbug.com/595385. 771 // http://crbug.com/419868, http://crbug.com/595385.
772 // Flaky on Windows and Linux as well: http://crbug.com/595385
771 #define MAYBE_OnSelectOptionFromDatalist DISABLED_OnSelectOptionFromDatalist 773 #define MAYBE_OnSelectOptionFromDatalist DISABLED_OnSelectOptionFromDatalist
772 #else 774 #else
773 #define MAYBE_OnSelectOptionFromDatalist OnSelectOptionFromDatalist 775 #define MAYBE_OnSelectOptionFromDatalist OnSelectOptionFromDatalist
774 #endif 776 #endif
775 IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, 777 IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest,
776 MAYBE_OnSelectOptionFromDatalist) { 778 MAYBE_OnSelectOptionFromDatalist) {
777 // Load the test page. 779 // Load the test page.
778 ASSERT_NO_FATAL_FAILURE(ui_test_utils::NavigateToURL( 780 ASSERT_NO_FATAL_FAILURE(ui_test_utils::NavigateToURL(
779 browser(), 781 browser(),
780 GURL(std::string(kDataURIPrefix) + 782 GURL(std::string(kDataURIPrefix) +
(...skipping 1041 matching lines...) Expand 10 before | Expand all | Expand 10 after
1822 std::string value; 1824 std::string value;
1823 ASSERT_TRUE(content::ExecuteScriptAndExtractString( 1825 ASSERT_TRUE(content::ExecuteScriptAndExtractString(
1824 cross_frame, 1826 cross_frame,
1825 "window.domAutomationController.send(" 1827 "window.domAutomationController.send("
1826 " document.getElementById('NAME_FIRST').value);", 1828 " document.getElementById('NAME_FIRST').value);",
1827 &value)); 1829 &value));
1828 EXPECT_EQ("Milton", value); 1830 EXPECT_EQ("Milton", value);
1829 } 1831 }
1830 1832
1831 } // namespace autofill 1833 } // namespace autofill
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698