Issue 281953002: Fix performance regression in regular expressions after Array.push() optimizations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 281953002: Fix performance regression in regular expressions after Array.push() optimizations (Closed)

Created:
6 years, 7 months ago by danno

Modified:
6 years, 7 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix performance regression in regular expressions after Array.push() optimizations R=yangguo@chromium.org LOG=N Committed: https://code.google.com/p/v8/source/detail?r=21348

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -12 lines)			Patch
M	src/code-stubs-hydrogen.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/regexp.js	View	1 chunk	+3 lines, -1 line	1 comment	Download
M	src/string.js	View	4 chunks	+5 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM with a comment. https://codereview.chromium.org/281953002/diff/1/src/regexp.js File src/regexp.js (right): https://codereview.chromium.org/281953002/diff/1/src/regexp.js#newcode117 src/regexp.js:117: result[0] = first_match; Is this ...

6 years, 7 months ago (2014-05-14 13:25:22 UTC) #1

danno

6 years, 7 months ago (2014-05-16 15:42:10 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r21348 (presubmit successful).

Expand Messages | Collapse Messages