Issue 2819523003: DBC follow up CL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2819523003: DBC follow up CL (Closed)

Created:
3 years, 8 months ago by Cutch

Modified:
3 years, 8 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

DBC follow up CL - [x] Hoist handle out of loop. - [x] Avoid allocating a handle. BUG= Committed: https://github.com/dart-lang/sdk/commit/7399d4bdec41f46057ae70149f1078befddddc96

Patch Set 1 #

Total comments: 1

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	runtime/vm/debugger.cc	View		3 chunks	+3 lines, -1 line	1 comment	Download
	M	tests/corelib/corelib.status	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

Committed patchset #1 (id:1) manually as 7399d4bdec41f46057ae70149f1078befddddc96.

3 years, 8 months ago (2017-04-13 14:38:22 UTC) #2

siva

lgtm https://codereview.chromium.org/2819523003/diff/1/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/2819523003/diff/1/runtime/vm/debugger.cc#newcode958 runtime/vm/debugger.cc:958: return Context::ZoneHandle(Context::null()); dead code?

3 years, 8 months ago (2017-04-13 16:10:28 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages