chrome/test/data/page_with_contenteditable.html - Issue 2819463002: Add a browser test for checking spelling in out-of-process subframes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/page_with_contenteditable.html

Issue 2819463002: Add a browser test for checking spelling in out-of-process subframes (Closed)

Patch Set: Fix threading error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/chrome_site_per_process_browsertest.cc ('K') | « chrome/browser/chrome_site_per_process_browsertest.cc ('k') | chrome/test/data/page_with_contenteditable_in_cross_site_subframe.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head></head>

	3 <body>

	4 This page has a contenteditable div.

	5 <div contenteditable>

	6 zz.

	7 </div>

	8 <script>

	9 document.querySelector('div').focus();
	alexmos 2017/04/13 22:39:10 Just curious, is the spellcheck IPC triggered by t Just curious, is the spellcheck IPC triggered by this focus(), or is it independent of it? (If it's triggered by focus(), another approach to the test could be just to use ExecuteScript to do the focus(). This would allow you to install the filter on the subframe's RenderFrameHost before that call, avoiding the need for TestBrowserClientForSpellCheck, IIUC. But what you have is fine too. :) ) Xiaocheng 2017/04/13 23:17:19 Yes, setting focus in contenteditable triggers spe Show quoted text On 2017/04/13 at 22:39:10, alexmos wrote: > Just curious, is the spellcheck IPC triggered by this focus(), or is it independent of it? > > (If it's triggered by focus(), another approach to the test could be just to use ExecuteScript to do the focus(). This would allow you to install the filter on the subframe's RenderFrameHost before that call, avoiding the need for TestBrowserClientForSpellCheck, IIUC. But what you have is fine too. :) ) Yes, setting focus in contenteditable triggers spellchecking. I tried adding filter before an ExecuteScript that sets focus, but it didn't work. I think it's because SpellCheckMessageFilter is added first, which handles the message and prevents other filters from handling the same message.
	10 </script>

	11 </body>

	12 </html>

OLD	NEW