Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Unified Diff: runtime/BUILD.gn

Issue 2819453002: GN: Remove dead target 'libdart' and dead flag 'dart_experimental_interpreter'. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/BUILD.gn
diff --git a/runtime/BUILD.gn b/runtime/BUILD.gn
index e834102c43e5db4099d80a745398d313ae43317e..852362a4df008277130464b18ccdd3e8edb5279e 100644
--- a/runtime/BUILD.gn
+++ b/runtime/BUILD.gn
@@ -29,8 +29,6 @@ declare_args() {
# Available options are: arm, arm64, mips, x64 and ia32
dart_target_arch = ""
- dart_experimental_interpreter = false
-
# The optimization level to use for debug builds.
dart_debug_optimization_level = "2"
}
@@ -58,33 +56,6 @@ config("dart_maybe_product_config") {
}
}
-# Adds the DART_PRECOMPILED_RUNTIME define if Flutter has specified "profile" or
-# "release" for dart_runtime_mode.
-config("dart_maybe_precompiled_runtime_config") {
- defines = []
-
- if (dart_runtime_mode != "develop" && dart_runtime_mode != "profile" &&
- dart_runtime_mode != "release") {
- print("Invalid |dart_runtime_mode|")
- assert(false)
- }
-
- if (dart_runtime_mode == "release") {
- if (dart_debug) {
- print("Debug and release mode are mutually exclusive.")
- }
- assert(!dart_debug)
-
- if (!dart_experimental_interpreter) {
- defines += [ "DART_PRECOMPILED_RUNTIME" ]
- }
- } else if (dart_runtime_mode == "profile") {
- if (!dart_experimental_interpreter) {
- defines += [ "DART_PRECOMPILED_RUNTIME" ]
- }
- }
-}
-
config("dart_precompiled_runtime_config") {
defines = []
defines += [ "DART_PRECOMPILED_RUNTIME" ]
@@ -104,10 +75,6 @@ config("dart_no_snapshot_config") {
config("dart_config") {
defines = []
- if (dart_experimental_interpreter) {
- dart_target_arch = "dbc"
- }
-
if (target_os == "android") {
defines += [ "TARGET_OS_ANDROID" ]
} else if (target_os == "fuchsia") {
@@ -250,16 +217,6 @@ template("libdart_library") {
}
}
-# TODO(rmacnak): Remove after updating all clients to use libdart_jit
-# or libdart_precompiled_runtime.
-libdart_library("libdart") {
- extra_configs = [ ":dart_maybe_precompiled_runtime_config" ]
- extra_deps = [
- "vm:libdart_lib",
- "vm:libdart_vm",
- ]
-}
-
libdart_library("libdart_jit") {
extra_deps = [
"vm:libdart_lib_jit",
« no previous file with comments | « no previous file | runtime/vm/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698