Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2819453002: GN: Remove dead target 'libdart' and dead flag 'dart_experimental_interpreter'. (Closed)

Created:
3 years, 8 months ago by rmacnak
Modified:
3 years, 8 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

GN: Remove dead target 'libdart' and dead flag 'dart_experimental_interpreter'. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/00c2af904f72fb5e955d40995a3aa170226bcf99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -71 lines) Patch
M runtime/BUILD.gn View 4 chunks +0 lines, -43 lines 0 comments Download
M runtime/vm/BUILD.gn View 4 chunks +2 lines, -28 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 8 months ago (2017-04-12 22:33:09 UTC) #2
zra
lgtm
3 years, 8 months ago (2017-04-12 22:39:42 UTC) #3
rmacnak
3 years, 8 months ago (2017-04-12 23:05:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
00c2af904f72fb5e955d40995a3aa170226bcf99 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698