Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 281943002: Add a top-level typed_mock package. (Closed)

Created:
6 years, 7 months ago by scheglov
Modified:
6 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 10

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -821 lines) Patch
M pkg/analysis_server/test/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download
D pkg/analysis_server/test/typed_mock.dart View 1 chunk +0 lines, -388 lines 0 comments Download
D pkg/analysis_server/test/typed_mock_test.dart View 1 chunk +0 lines, -394 lines 0 comments Download
A + pkg/typed_mock/lib/typed_mock.dart View 1 10 chunks +52 lines, -10 lines 0 comments Download
A + pkg/typed_mock/pubspec.yaml View 1 chunk +2 lines, -4 lines 0 comments Download
A + pkg/typed_mock/test/typed_mock_test.dart View 1 2 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
6 years, 7 months ago (2014-05-14 06:27:27 UTC) #1
danrubel
lgtm https://codereview.chromium.org/281943002/diff/1/pkg/typed_mock/test/typed_mock_test.dart File pkg/typed_mock/test/typed_mock_test.dart (right): https://codereview.chromium.org/281943002/diff/1/pkg/typed_mock/test/typed_mock_test.dart#newcode6 pkg/typed_mock/test/typed_mock_test.dart:6: import '../lib/typed_mock.dart' as typed_mocks show equals; Use import ...
6 years, 7 months ago (2014-05-14 10:45:08 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/281943002/diff/1/pkg/typed_mock/lib/typed_mock.dart File pkg/typed_mock/lib/typed_mock.dart (right): https://codereview.chromium.org/281943002/diff/1/pkg/typed_mock/lib/typed_mock.dart#newcode7 pkg/typed_mock/lib/typed_mock.dart:7: /// Use it when you want the mock ...
6 years, 7 months ago (2014-05-14 14:04:14 UTC) #3
scheglov
https://codereview.chromium.org/281943002/diff/1/pkg/typed_mock/lib/typed_mock.dart File pkg/typed_mock/lib/typed_mock.dart (right): https://codereview.chromium.org/281943002/diff/1/pkg/typed_mock/lib/typed_mock.dart#newcode7 pkg/typed_mock/lib/typed_mock.dart:7: /// Use it when you want the mock to ...
6 years, 7 months ago (2014-05-14 15:35:55 UTC) #4
scheglov
6 years, 7 months ago (2014-05-14 15:36:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r36170 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698