Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/perf/benchmarks/tab_switching.py

Issue 2819423002: Support flag --tabset-repeat on benchmark tab_switching (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/tab_switching.py
diff --git a/tools/perf/benchmarks/tab_switching.py b/tools/perf/benchmarks/tab_switching.py
index a451fec2256ac0a641663c264e14ca32de4d1674..b1cf856ba0e07c7e771c11229e6bfcc52483f381 100644
--- a/tools/perf/benchmarks/tab_switching.py
+++ b/tools/perf/benchmarks/tab_switching.py
@@ -2,11 +2,14 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import os
+
from core import perf_benchmark
from measurements import tab_switching
-import page_sets
+from page_sets.system_health import multi_tab_stories
from telemetry import benchmark
+from telemetry import story
@benchmark.Owner(emails=['vovoy@chromium.org'],
@@ -24,9 +27,19 @@ class TabSwitchingTypical25(perf_benchmark.PerfBenchmark):
"""
test = tab_switching.TabSwitching
+ @classmethod
+ def AddBenchmarkCommandLineArgs(cls, parser):
+ parser.add_option('--tabset-repeat', type='int', default=1,
+ help='repeat tab page set')
+
def CreateStorySet(self, options):
- return page_sets.SystemHealthStorySet(platform='desktop',
- case='multitab:misc')
+ story_set = story.StorySet(
+ archive_data_file='../page_sets/data/system_health_desktop.json',
+ base_dir=os.path.dirname(os.path.abspath(__file__)),
+ cloud_storage_bucket=story.PARTNER_BUCKET)
+ story_set.AddStory(multi_tab_stories.MultiTabTypical24Story(
+ story_set, False, options.tabset_repeat))
+ return story_set
perezju 2017/04/21 11:59:48 Hmm, this doesn't make me supper happy. But I gues
nednguyen 2017/04/21 12:14:02 I think in general, we should not allow people par
@classmethod
def Name(cls):

Powered by Google App Engine
This is Rietveld 408576698