Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1360)

Unified Diff: chrome/browser/extensions/extension_app_icon.h

Issue 2819413003: Refactor extension app icon. (Closed)
Patch Set: tiny nit Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_app_icon.h
diff --git a/chrome/browser/extensions/extension_app_icon.h b/chrome/browser/extensions/extension_app_icon.h
new file mode 100644
index 0000000000000000000000000000000000000000..61ac59e9f99273e3fd77f5c150a4dcce42960dac
--- /dev/null
+++ b/chrome/browser/extensions/extension_app_icon.h
@@ -0,0 +1,81 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_APP_ICON_H_
+#define CHROME_BROWSER_EXTENSIONS_EXTENSION_APP_ICON_H_
+
+#include <memory>
+#include <string>
+
+#include "base/callback.h"
+#include "base/macros.h"
+#include "extensions/browser/extension_icon_image.h"
+#include "ui/gfx/image/image_skia.h"
+
+namespace content {
+class BrowserContext;
+}
+
+namespace extensions {
+
+class Extension;
+class ExtensionAppIconDelegate;
+class IconImage;
+
+// This represents how an extension icon should finally look. As a base,
+// extension icon is used and effects that depend on extension type, state and
+// some external conditions are applied. Resulting image is sent via
+// ExtensionAppIconDelegate. Several updates are expected in case extension
+// state or some external conditions are changed.
+class ExtensionAppIcon : public extensions::IconImage::Observer {
+ public:
+ using Closure = base::Callback<void(ExtensionAppIcon*)>;
xiyuan 2017/04/20 17:52:46 nit: Closure -> CloseCallback (or DestroyCallback)
khmel 2017/04/20 18:01:11 Done.
+
+ ExtensionAppIcon(ExtensionAppIconDelegate* delegate,
+ content::BrowserContext* context,
+ Closure close_callback,
+ const std::string& app_id,
+ int resource_size_in_dip);
+ ~ExtensionAppIcon() override;
+
+ void Reload();
+
+ // Returns true if icon is loaded and attached to valid extension.
+ bool IsValid() const;
+
+ void UpdateIcon();
+
+ void EnsureRepsForSupportedScales();
+
+ const gfx::ImageSkia& image_skia() const { return image_skia_; }
+ const std::string& app_id() const { return app_id_; }
+ content::BrowserContext* context() { return context_; }
+
+ private:
+ const extensions::Extension* GetExtension();
+
+ // extensions::IconImage::Observer:
+ void OnExtensionIconImageChanged(extensions::IconImage* image) override;
+
+ // Unowned pointers.
+ ExtensionAppIconDelegate* const delegate_;
+ content::BrowserContext* const context_;
+
+ Closure close_callback_;
+
+ const std::string app_id_;
+
+ const int resource_size_in_dip_;
+
+ // Contains current icon image.
+ gfx::ImageSkia image_skia_;
+
+ std::unique_ptr<extensions::IconImage> icon_;
+
+ DISALLOW_COPY_AND_ASSIGN(ExtensionAppIcon);
+};
+
+} // namespace extensions
+
+#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_APP_ICON_H_

Powered by Google App Engine
This is Rietveld 408576698