Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: chrome/browser/ui/app_list/arc/arc_app_list_prefs.h

Issue 2819413003: Refactor extension app icon. (Closed)
Patch Set: nit Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/app_icon_loader.h ('k') | chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
diff --git a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h b/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
index 22682cc695af334954fbde3056a5b91fb0152138..a7eed495ef1b4d93420270fdb7ce996a0c37d057 100644
--- a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
+++ b/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
@@ -138,8 +138,12 @@ class ArcAppListPrefs
// Notifies that package has been modified.
virtual void OnPackageModified(
const arc::mojom::ArcPackageInfo& package_info) {}
- // Notifies that package has been uninstalled.
- virtual void OnPackageRemoved(const std::string& package_name) {}
+ // Notifies that package has been removed from the system. |uninstalled| is
+ // set to true in case package was uninstalled by user or sync.
+ // OnPackageRemoved is called for each active package with |uninstalled| set
+ // to false in case the user opts out the Play Store.
+ virtual void OnPackageRemoved(const std::string& package_name,
+ bool uninstalled) {}
// Notifies sync date type controller the model is ready to start.
virtual void OnPackageListInitialRefreshed() {}
@@ -306,8 +310,10 @@ class ArcAppListPrefs
// Returns list of packages from prefs. If |installed| is set to true then
// returns currently installed packages. If not, returns list of packages that
// where uninstalled. Note, we store uninstall packages only for packages of
- // default apps.
- std::vector<std::string> GetPackagesFromPrefs(bool installed) const;
+ // default apps. If |check_arc_alive| is set to true then package list is
+ // filled only in case ARC is currently active.
+ std::vector<std::string> GetPackagesFromPrefs(bool check_arc_alive,
+ bool installed) const;
void AddApp(const arc::mojom::AppInfo& app_info);
void AddAppAndShortcut(bool app_ready,
@@ -329,7 +335,7 @@ class ArcAppListPrefs
const std::string& package_name);
void DisableAllApps();
- void RemoveAllApps();
+ void RemoveAllAppsAndPackages();
std::vector<std::string> GetAppIdsNoArcEnabledCheck() const;
std::unordered_set<std::string> GetAppsAndShortcutsForPackage(
const std::string& package_name,
« no previous file with comments | « chrome/browser/ui/app_icon_loader.h ('k') | chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698