Chromium Code Reviews| Index: chrome/browser/ui/app_list/arc/arc_app_list_prefs.h |
| diff --git a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h b/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h |
| index 2170d9f8451560a5e34a297f47f657731da32f9c..b7b3b34420930c09a816458179d90520eadc7baf 100644 |
| --- a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h |
| +++ b/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h |
| @@ -138,8 +138,12 @@ class ArcAppListPrefs |
| // Notifies that package has been modified. |
| virtual void OnPackageModified( |
| const arc::mojom::ArcPackageInfo& package_info) {} |
| - // Notifies that package has been uninstalled. |
| - virtual void OnPackageRemoved(const std::string& package_name) {} |
| + // Notifies that package has been removed from the system. |uninstalled| is |
| + // set to true in case package was uninstalled by user or sync. |
| + // OnPackageRemoved is called for each active package with |uninstalled| is |
|
msw
2017/05/08 19:59:54
nit: "with |uninstalled| set", (no "is")
khmel
2017/05/09 00:05:06
Done.
|
| + // set to false in case the user opts out the Play Store. |
| + virtual void OnPackageRemoved(const std::string& package_name, |
| + bool uninstalled) {} |
| // Notifies sync date type controller the model is ready to start. |
| virtual void OnPackageListInitialRefreshed() {} |
| @@ -307,7 +311,8 @@ class ArcAppListPrefs |
| // returns currently installed packages. If not, returns list of packages that |
| // where uninstalled. Note, we store uninstall packages only for packages of |
| // default apps. |
| - std::vector<std::string> GetPackagesFromPrefs(bool installed) const; |
| + std::vector<std::string> GetPackagesFromPrefs(bool check_arc_alive, |
|
msw
2017/05/08 19:59:54
nit: document |check_arc_alive| in the function co
khmel
2017/05/09 00:05:06
Done.
|
| + bool installed) const; |
| void AddApp(const arc::mojom::AppInfo& app_info); |
| void AddAppAndShortcut(bool app_ready, |
| @@ -329,7 +334,7 @@ class ArcAppListPrefs |
| const std::string& package_name); |
| void DisableAllApps(); |
| - void RemoveAllApps(); |
| + void RemoveAllAppsAndPackages(); |
| std::vector<std::string> GetAppIdsNoArcEnabledCheck() const; |
| std::unordered_set<std::string> GetAppsAndShortcutsForPackage( |
| const std::string& package_name, |