Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Unified Diff: chrome/browser/ui/ash/launcher/launcher_extension_app_updater.h

Issue 2819413003: Refactor extension app icon. (Closed)
Patch Set: Devlin's comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/launcher_extension_app_updater.h
diff --git a/chrome/browser/ui/ash/launcher/launcher_extension_app_updater.h b/chrome/browser/ui/ash/launcher/launcher_extension_app_updater.h
index a9588d05b3d068e2607424124bde4bc5ee8233ba..52a95a02e5dbb73cffb639b3c8d81186f9bd1a64 100644
--- a/chrome/browser/ui/ash/launcher/launcher_extension_app_updater.h
+++ b/chrome/browser/ui/ash/launcher/launcher_extension_app_updater.h
@@ -10,10 +10,8 @@
#include "chrome/browser/ui/ash/launcher/launcher_app_updater.h"
#include "extensions/browser/extension_registry_observer.h"
-namespace extensions {
-class ExtensionSet;
-} // namespace extensions
-
+// TODO (khmel), this is not Launcher class. Consider moving this to proper
Devlin 2017/05/01 14:51:11 nit: s/TODO (khmel), /TODO(khmel):
khmel 2017/05/01 20:18:19 Done.
+// place.
class LauncherExtensionAppUpdater
: public LauncherAppUpdater,
public extensions::ExtensionRegistryObserver,
@@ -38,16 +36,16 @@ class LauncherExtensionAppUpdater
// ArcAppListPrefs::Observer
void OnPackageInstalled(
const arc::mojom::ArcPackageInfo& package_info) override;
- void OnPackageRemoved(const std::string& package_name) override;
+ void OnPackageRemoved(const std::string& package_name,
+ bool uninstalled) override;
+ void OnPackageListInitialRefreshed() override;
private:
void StartObservingExtensionRegistry();
void StopObservingExtensionRegistry();
- void UpdateHostedApps();
- void UpdateHostedApps(const extensions::ExtensionSet& extensions);
- void UpdateHostedApp(const std::string& app_id);
- void UpdateEquivalentHostedApp(const std::string& arc_package_name);
+ void UpdateApp(const std::string& app_id);
+ void UpdateEquivalentApp(const std::string& arc_package_name);
extensions::ExtensionRegistry* extension_registry_ = nullptr;

Powered by Google App Engine
This is Rietveld 408576698