Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4019)

Unified Diff: chrome/browser/extensions/extension_app_icon_service.h

Issue 2819413003: Refactor extension app icon. (Closed)
Patch Set: Devlin's comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_app_icon_service.h
diff --git a/chrome/browser/extensions/extension_app_icon_service.h b/chrome/browser/extensions/extension_app_icon_service.h
new file mode 100644
index 0000000000000000000000000000000000000000..3abc476647a694fb273826e69f46ba931e6b00a9
--- /dev/null
+++ b/chrome/browser/extensions/extension_app_icon_service.h
@@ -0,0 +1,92 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_APP_ICON_SERVICE_H_
+#define CHROME_BROWSER_EXTENSIONS_EXTENSION_APP_ICON_SERVICE_H_
+
+#include <map>
+#include <memory>
+#include <set>
+
+#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
+#include "base/scoped_observer.h"
+#include "components/keyed_service/core/keyed_service.h"
+#include "extensions/browser/extension_registry_observer.h"
+
+namespace content {
+class BrowserContext;
+}
+
+namespace extensions {
+
+class ExtensionAppIcon;
+class ExtensionAppIconDelegate;
+
+// Factory for ExtensionAppIcon. Each created icon is tracked by this service.
+// Once some condition that affects how extension app icon should look is
+// changed then corresponded app icons are automatically updated. This service
+// is bound to content::BrowserContext.
+// Usage: ExtensionAppIconService::Get(context)->CreateIcon().
+class ExtensionAppIconService : public KeyedService,
+ public ExtensionRegistryObserver {
+ public:
+ // See the Create methods.
Devlin 2017/05/01 14:51:11 Obsolete?
khmel 2017/05/01 20:18:18 Done.
+ explicit ExtensionAppIconService(content::BrowserContext* context);
+
+ ~ExtensionAppIconService() override;
+
+ // Convenience function to get the ExtensionAppIconService for a
+ // BrowserContext.
+ static ExtensionAppIconService* Get(content::BrowserContext* context);
+
+ // Creates extension app icon for requested app and size. Icon updates are
+ // dispatched via |delegate|.
+ std::unique_ptr<ExtensionAppIcon> CreateIcon(
+ ExtensionAppIconDelegate* delegate,
+ const std::string& app_id,
+ int resource_size_in_dip);
+
+ // KeyedService:
+ void Shutdown() override;
+
+ private:
+ friend class ExtensionAppIcon;
Devlin 2017/05/01 14:51:11 Is this needed?
khmel 2017/05/01 20:18:18 Done.
+
+ class Updater;
+ using IconMap = std::map<std::string, std::set<ExtensionAppIcon*>>;
+
+ // Called from ExtensionAppIcon DTOR.
+ void OnIconDestroyed(ExtensionAppIcon* icon);
+
+ // Called from Updater when corresponded app icons need to be updated.
+ void OnAppUpdated(const std::string& app_id);
+
+ // ExtensionRegistryObserver:
+ void OnExtensionLoaded(content::BrowserContext* browser_context,
+ const Extension* extension) override;
+
+ void OnExtensionUnloaded(content::BrowserContext* browser_context,
+ const Extension* extension,
+ UnloadedExtensionInfo::Reason reason) override;
+
+ // Unowned pointer.
+ content::BrowserContext* context_;
+
+#if defined(OS_CHROMEOS)
+ std::unique_ptr<Updater> app_updater_;
+#endif
+
+ IconMap icon_map_;
+
+ ScopedObserver<ExtensionRegistry, ExtensionRegistryObserver> observer_;
+
+ base::WeakPtrFactory<ExtensionAppIconService> weak_ptr_factory_;
+
+ DISALLOW_COPY_AND_ASSIGN(ExtensionAppIconService);
+};
+
+} // namespace extensions
+
+#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_APP_ICON_SERVICE_H_

Powered by Google App Engine
This is Rietveld 408576698