Refactor extension app icon.

chrome/browser/ui/app_list/arc/arc_app_list_prefs.h

Index: chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
diff --git a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h b/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
index 05d9b13180513a6e8081e7f6e8ab44a4d69d3d55..8fd63c76b8827283770534e8052a06b33efb0806 100644
--- a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
+++ b/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
@@ -138,8 +138,10 @@ class ArcAppListPrefs
     // Notifies that package has been modified.
     virtual void OnPackageModified(
         const arc::mojom::ArcPackageInfo& package_info) {}
-    // Notifies that package has been uninstalled.
-    virtual void OnPackageRemoved(const std::string& package_name) {}
+    // Notifies that package has been removed from the system. |uninstalled| is
+    // set to true in case package was uninstalled by user or sync.
+    virtual void OnPackageRemoved(const std::string& package_name,
+                                  bool uninstalled) {}

[khmel, 2017/04/18 17:15:46]

This is to fix badging in case we opts out ARC. Badging is currently implemented
tracking onPackage event but Removed even was not issued on ARC opt out. This
extends this interface and issue OnPackageRemoved events with uninstalled =
false in case ARC is opted out

[xiyuan, 2017/04/18 20:43:01]

Can you also mention this in the comment? i.e. when OnPackageRemoved is called
with uninstalled = false.

[khmel, 2017/04/20 00:13:38]

Done.

     // Notifies sync date type controller the model is ready to start.
     virtual void OnPackageListInitialRefreshed() {}
 
@@ -303,7 +305,8 @@ class ArcAppListPrefs
   // returns currently installed packages. If not, returns list of packages that
   // where uninstalled. Note, we store uninstall packages only for packages of
   // default apps.
-  std::vector<std::string> GetPackagesFromPrefs(bool installed) const;
+  std::vector<std::string> GetPackagesFromPrefs(bool check_arc_alive,
+                                                bool installed) const;
 
   void AddApp(const arc::mojom::AppInfo& app_info);
   void AddAppAndShortcut(bool app_ready,
@@ -325,7 +328,7 @@ class ArcAppListPrefs
                               const std::string& package_name);
 
   void DisableAllApps();
-  void RemoveAllApps();
+  void RemoveAllAppsAndPackages();
   std::vector<std::string> GetAppIdsNoArcEnabledCheck() const;
   // Enumerates apps from preferences and notifies listeners about available
   // apps while ARC is not started yet. All apps in this case have disabled