Refactor extension app icon.

chrome/browser/extensions/extension_app_icon_service_factory.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/extension_app_icon_service_factory.h"
+
+#include "chrome/browser/extensions/extension_app_icon_service.h"
+#include "chrome/browser/profiles/incognito_helpers.h"
+#include "components/keyed_service/content/browser_context_dependency_manager.h"
+
+namespace extensions {
+
+// static
+ExtensionAppIconService* ExtensionAppIconServiceFactory::GetForBrowserContext(
+    content::BrowserContext* context) {
+  return static_cast<ExtensionAppIconService*>(
+      GetInstance()->GetServiceForBrowserContext(context, true));
+}
+
+// static
+ExtensionAppIconServiceFactory* ExtensionAppIconServiceFactory::GetInstance() {
+  return base::Singleton<ExtensionAppIconServiceFactory>::get();
+}
+
+ExtensionAppIconServiceFactory::ExtensionAppIconServiceFactory()
+    : BrowserContextKeyedServiceFactory(
+          "ExtensionAppIconService",
+          BrowserContextDependencyManager::GetInstance()) {}

[xiyuan, 2017/04/18 20:43:01]

DependsOn(ExtensionRegistryFactory::GetInstance());

since we sort of depend on it (ExtensionAppIcon uses ExtensionRegistry).

[khmel, 2017/04/20 00:13:38]

Thanks for catching this! actually I was seeking the way adding the dependency.

+
+ExtensionAppIconServiceFactory::~ExtensionAppIconServiceFactory() = default;
+
+KeyedService* ExtensionAppIconServiceFactory::BuildServiceInstanceFor(
+    content::BrowserContext* context) const {
+  return ExtensionAppIconService::Create(context);
+}
+
+content::BrowserContext* ExtensionAppIconServiceFactory::GetBrowserContextToUse(
+    content::BrowserContext* context) const {
+  // This matches the logic in ExtensionSyncServiceFactory, which uses the
+  // original browser context.
+  return chrome::GetBrowserContextRedirectedInIncognito(context);
+}
+
+}  // namespace extensions