[CrOS Tether] Update NetworkState to include tether properties and integrate into NetworkStateHandl…

chrome/browser/resources/settings/internet_page/network_summary.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Polymer element for displaying a summary of network states
  * by type: Ethernet, WiFi, Cellular, WiMAX, and VPN.
  */
 
 /** @typedef {chrome.networkingPrivate.DeviceStateProperties} */
@@ skipping 264 matching lines @@
     var activeNetworkStatesByType =
         /** @type {!Map<string, !CrOnc.NetworkStateProperties>} */ (new Map);
 
     // Complete list of states by type.
     /** @type {!NetworkStateListObject} */ var newNetworkStateLists = {
       Ethernet: [],
       WiFi: [],
       Cellular: [],
       WiMAX: [],
       VPN: [],
+      Tether: [],

[stevenjb, 2017/04/19 21:16:02]

We shouldn't add this here until we use it.

[Kyle Horimoto, 2017/04/19 22:31:04]

Without this change, the settings page has a JavaScript error below on the line:

newNetworkStateLists[type].push(networkState);

We need to include this edit with this CL to prevent breakage.

[stevenjb, 2017/04/19 22:37:34]

What's the error? We should probably fix that instead (e.g. test
newNetworkStateLists.hasOwnProperty(type) first).

[Kyle Horimoto, 2017/04/19 23:08:59]

Done.

     };
 
     var firstConnectedNetwork = null;
     networkStates.forEach(function(networkState) {
       var type = networkState.Type;
       if (!activeNetworkStatesByType.has(type)) {
         activeNetworkStatesByType.set(type, networkState);
         if (!firstConnectedNetwork && networkState.Type != CrOnc.Type.VPN &&
             networkState.ConnectionState == CrOnc.ConnectionState.CONNECTED) {
           firstConnectedNetwork = networkState;
@@ skipping 34 matching lines @@
       newActiveNetworkStates.push(state);
       this.activeNetworkIds_.add(state.GUID);
     }
 
     this.deviceStates = newDeviceStates;
     this.networkStateLists_ = newNetworkStateLists;
     // Set activeNetworkStates last to rebuild the dom-repeat.
     this.activeNetworkStates_ = newActiveNetworkStates;
   },
 });