Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: tools/perf/benchmarks/blink_perf.js

Issue 2819343002: Support tracing metrics for measureTime & measureFrameTime method in blink_perf (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/blink_perf.js
diff --git a/tools/perf/benchmarks/blink_perf.js b/tools/perf/benchmarks/blink_perf.js
index 465e1ffd7409837bc95bf5c05a6b1e3f49718e84..086e2bf84ceb4115b379af6caf552b21ea9a9939 100644
--- a/tools/perf/benchmarks/blink_perf.js
+++ b/tools/perf/benchmarks/blink_perf.js
@@ -12,6 +12,24 @@ testRunner.notifyDone = function() {
this.isDone = true;
};
+testRunner.supportTracing = true;
+
+// If this is true, blink_perf tests is put on paused waiting for tracing to
+// be started. |scheduleTestRun| should be invoked after tracing is started
+// to continue blink perf test.
+testRunner.isWaitingForTracingStart = false;
+
+testRunner.traceEventsToMeasure = undefined;
+
+testRunner.startTracing = function(tracingCategories, scheduleTestRun) {
Xianzhu 2017/04/21 01:31:51 Why traceEventsToMeasure is set as a variable whil
nednguyen 2017/04/24 20:55:21 I want to keep startTracing to be focused on setti
Xianzhu 2017/04/24 21:03:07 SGTM.
nednguyen 2017/04/24 22:31:41 Done.
+ this.tracingCategories = tracingCategories;
+ this.scheduleTestRun = scheduleTestRun;
+ this.isWaitingForTracingStart = true;
+}
+
+testRunner.stopTracing = function() {
+}
+
window.GCController = {};
GCController.collect = function() {

Powered by Google App Engine
This is Rietveld 408576698