Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 281933002: Add size info to texture upload traces. (Closed)

Created:
6 years, 7 months ago by Vangelis Kokkevis
Modified:
6 years, 7 months ago
Reviewers:
Zhenyao Mo, vmiura, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add size info to texture upload traces. Add texture width and height to existing texture upload trace calls in the command buffer service. BUG=373074 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271203

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Vangelis Kokkevis
Ready for review, thanks!
6 years, 7 months ago (2014-05-14 00:29:39 UTC) #1
vmiura
LGTM. +OWNERS
6 years, 7 months ago (2014-05-14 01:32:31 UTC) #2
piman
lgtm
6 years, 7 months ago (2014-05-14 01:36:08 UTC) #3
Vangelis Kokkevis
The CQ bit was checked by vangelis@chromium.org
6 years, 7 months ago (2014-05-14 16:17:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vangelis@chromium.org/281933002/1
6 years, 7 months ago (2014-05-14 16:18:04 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 17:53:42 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-14 17:58:11 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/183954)
6 years, 7 months ago (2014-05-14 17:58:12 UTC) #8
Vangelis Kokkevis
The CQ bit was checked by vangelis@chromium.org
6 years, 7 months ago (2014-05-14 18:14:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vangelis@chromium.org/281933002/1
6 years, 7 months ago (2014-05-14 18:14:42 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 18:40:17 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-14 18:55:45 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/26696) linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/31377)
6 years, 7 months ago (2014-05-14 18:55:45 UTC) #13
Vangelis Kokkevis
The CQ bit was checked by vangelis@chromium.org
6 years, 7 months ago (2014-05-14 22:00:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vangelis@chromium.org/281933002/1
6 years, 7 months ago (2014-05-14 22:01:43 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 22:20:28 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-14 22:38:01 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/31588)
6 years, 7 months ago (2014-05-14 22:38:02 UTC) #18
Vangelis Kokkevis
The CQ bit was checked by vangelis@chromium.org
6 years, 7 months ago (2014-05-16 22:32:11 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vangelis@chromium.org/281933002/1
6 years, 7 months ago (2014-05-16 23:32:09 UTC) #20
commit-bot: I haz the power
6 years, 7 months ago (2014-05-17 15:33:14 UTC) #21
Message was sent while issue was closed.
Change committed as 271203

Powered by Google App Engine
This is Rietveld 408576698