Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: chromeos/components/tether/tether_connector_unittest.cc

Issue 2819303002: Changed wifi arcs to mobile bars for Tether network. (Closed)
Patch Set: khorimoto@ comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/components/tether/tether_connector_unittest.cc
diff --git a/chromeos/components/tether/tether_connector_unittest.cc b/chromeos/components/tether/tether_connector_unittest.cc
index beae897e7f380fbd7e394d6d3788cf77914ee31b..67d19cdbcb2befc96699abda64dd70682f38ec69 100644
--- a/chromeos/components/tether/tether_connector_unittest.cc
+++ b/chromeos/components/tether/tether_connector_unittest.cc
@@ -358,8 +358,7 @@ TEST_F(TetherConnectorTest, TestSuccessfulConnection) {
EXPECT_EQ(kPassword, fake_wifi_hotspot_connector_->most_recent_password());
SuccessfullyJoinWifiNetwork();
- // The active host should now be connected, and the tether and Wi-Fi networks
- // should be associated.
+ // The active host should now be connected
Ryan Hansberry 2017/04/27 16:32:27 Comments should end with periods (and in general s
lesliewatkins 2017/04/28 21:30:43 Done.
EXPECT_EQ(ActiveHost::ActiveHostStatus::CONNECTED,
fake_active_host_->GetActiveHostStatus());
EXPECT_EQ(test_devices_[0].GetDeviceId(),
@@ -367,6 +366,7 @@ TEST_F(TetherConnectorTest, TestSuccessfulConnection) {
EXPECT_EQ(GetTetherNetworkGuid(test_devices_[0].GetDeviceId()),
fake_active_host_->GetTetherNetworkGuid());
EXPECT_EQ(kWifiNetworkGuid, fake_active_host_->GetWifiNetworkGuid());
+
VerifyTetherAndWifiNetworkAssociation(
Kyle Horimoto 2017/04/27 01:28:07 You forgot to remove the association code from Tet
lesliewatkins 2017/04/28 21:30:43 Done.
GetTetherNetworkGuid(test_devices_[0].GetDeviceId()));
EXPECT_EQ(kSuccessResult, GetResultAndReset());

Powered by Google App Engine
This is Rietveld 408576698