Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chromeos/components/tether/tether_connector_unittest.cc

Issue 2819303002: Changed wifi arcs to mobile bars for Tether network. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/components/tether/tether_connector_unittest.cc
diff --git a/chromeos/components/tether/tether_connector_unittest.cc b/chromeos/components/tether/tether_connector_unittest.cc
index 7788183283f3c622372071b5507d2b3677e1924a..bb44d3f5610cf581e4a0e53642a0366932b0f917 100644
--- a/chromeos/components/tether/tether_connector_unittest.cc
+++ b/chromeos/components/tether/tether_connector_unittest.cc
@@ -212,7 +212,7 @@ class TetherConnectorTest : public NetworkStateTest {
fake_wifi_hotspot_connector_->CallMostRecentCallback(kWifiNetworkGuid);
}
- void VerifyTetherAndWifiNetworkAssociation(
+ /* void VerifyTetherAndWifiNetworkAssociation(
Kyle Horimoto 2017/04/17 19:50:04 Remove this if it is unused.
lesliewatkins 2017/04/27 00:33:53 Done.
const std::string& tether_network_guid) {
const NetworkState* tether_network_state =
network_state_handler()->GetNetworkStateFromGuid(tether_network_guid);
@@ -223,7 +223,7 @@ class TetherConnectorTest : public NetworkStateTest {
network_state_handler()->GetNetworkStateFromGuid(kWifiNetworkGuid);
EXPECT_TRUE(wifi_network_state);
EXPECT_EQ(tether_network_guid, wifi_network_state->tether_guid());
- }
+ }*/
const std::vector<cryptauth::RemoteDevice> test_devices_;
const base::MessageLoop message_loop_;
@@ -344,8 +344,7 @@ TEST_F(TetherConnectorTest, TestSuccessfulConnection) {
EXPECT_EQ(kPassword, fake_wifi_hotspot_connector_->most_recent_password());
SuccessfullyJoinWifiNetwork();
- // The active host should now be connected, and the tether and Wi-Fi networks
- // should be associated.
+ // The active host should now be connected
EXPECT_EQ(ActiveHost::ActiveHostStatus::CONNECTED,
fake_active_host_->GetActiveHostStatus());
EXPECT_EQ(test_devices_[0].GetDeviceId(),
@@ -353,8 +352,6 @@ TEST_F(TetherConnectorTest, TestSuccessfulConnection) {
EXPECT_EQ(GetTetherNetworkGuid(test_devices_[0].GetDeviceId()),
fake_active_host_->GetTetherNetworkGuid());
EXPECT_EQ(kWifiNetworkGuid, fake_active_host_->GetWifiNetworkGuid());
- VerifyTetherAndWifiNetworkAssociation(
- GetTetherNetworkGuid(test_devices_[0].GetDeviceId()));
}
TEST_F(TetherConnectorTest, TestNewConnectionAttemptDuringFetch_SameDevice) {

Powered by Google App Engine
This is Rietveld 408576698